taipy icon indicating copy to clipboard operation
taipy copied to clipboard

🐛 `_on_status_changed` triggers reload of non persisted job

Open gmarabout opened this issue 2 years ago • 0 comments

Context

When we create a job, the "job manager" set the callback before the job is saved. See https://github.com/Avaiga/taipy/blob/develop/taipy/core/job/_job_manager.py#L54

When the _on_status_changed is called, it currently check if the status is not "SUBMITTED" which, by accessing the status property, triggers a reload via the "self reloader". See https://github.com/Avaiga/taipy/blob/develop/taipy/core/job/job.py#L311

This eventually causes an error in the log:

[2024-01-22 14:05:22][Taipy][ERROR] Job not found: JOB_score_task_737ac665-5cd2-49ca-b235-d5d1cccb0642

The _on_status_change callback setter can safely avoid to reload by not checking the status field at all and not calling any callback anyway.

Changes

  • [removed] The status field is not checked anymore and the callbacks are no longer called directly here.

gmarabout avatar Jan 22 '24 16:01 gmarabout