taipy icon indicating copy to clipboard operation
taipy copied to clipboard
verified publisher icon Avaiga

Updated utils.py for better warning messages

Open srinivaspavan9 opened this issue 2 years ago • 3 comments

Updated Warning Message in utils.py for Issue #379

This PR addresses BUG-Inputting the wrong column name in a chart reports empty data (#379). The issue was due to the misleading warning message in utils.py, which implied an empty DataFrame when a non-existent column name was used.

Changes Made:

  • Updated the warning message to clearly indicate when a column is not found, and to list the available columns in the DataFrame.
  • This change aims to provide clearer and more accurate information, avoiding confusion about the state of the DataFrame.

Screenshot after the change:

image

srinivaspavan9 avatar Dec 18 '23 01:12 srinivaspavan9

how do i resolve these linter errors

srinivaspavan9 avatar Jan 02 '24 11:01 srinivaspavan9

how do i resolve these linter errors

Hello @srinivaspavan9, sorry for the late response.

First you need to merge your branch with the latest Avaiga:develop branch. Then, in the linter error log, I saw that

/taipy/gui/_renderers/utils.py:35:121: E501 line too long (191 > 120 characters)

which means that the line you edited is too long.

Please address the issue before we can merge your change to Taipy. Thank you

trgiangdo avatar Feb 07 '24 07:02 trgiangdo

Hi @srinivaspavan9, Thanks for your work. Taipy 3.1 is coming soon and it would be nice to include your contribution. We're freezing the code very soon (likely tomorrow). Can you finish this PR before that deadline ? Fred

FredLL-Avaiga avatar Feb 27 '24 13:02 FredLL-Avaiga