taipy icon indicating copy to clipboard operation
taipy copied to clipboard

Data Node viewer- Limit the table view to 25 rows

Open FlorianJacta opened this issue 2 years ago • 12 comments

Improvement

Limit the table view to only 25 rows for the Data Node view. The user can then change its size, but having more rows by default is not optimal in my opinion.

FlorianJacta avatar Nov 06 '23 15:11 FlorianJacta

We could set the page size to 25 ...

FredLL-Avaiga avatar Mar 22 '24 15:03 FredLL-Avaiga

We can reduce the default nb of rows It would also be good to align with the table control.

jrobinAV avatar Apr 05 '24 12:04 jrobinAV

The default page size for table is 50 I believe (that's what was used by default here)

FredLL-Avaiga avatar Apr 05 '24 12:04 FredLL-Avaiga

Hello ,I would like to work on this issue! Could you please assign me on it? thank you in advance!

ioannastantzou avatar Apr 14 '24 10:04 ioannastantzou

@FredLL-Avaiga @FabienLelaquais Could we assign this issue to @ioannastantzou and show how to do it? Is it in taipy/frontend/taipy/src /DataNodeViewer.tsx?

FlorianJacta avatar Apr 16 '24 08:04 FlorianJacta

I guess that would be the pageSize property of the Taipy Gui Table component https://vscode.dev/github/Avaiga/taipy/blob/feature/%231044-chat/frontend/taipy/src/DataNodeTable.tsx#L200

FredLL-Avaiga avatar Apr 16 '24 12:04 FredLL-Avaiga

hello and thank you! could i be assigned to start working on it?

ioannastantzou avatar Apr 16 '24 12:04 ioannastantzou

So just a quick question , we want to make it by default only 25 rows or make it adjustable for the user to choose? thank you!

ioannastantzou avatar Apr 18 '24 18:04 ioannastantzou

So just a quick question , we want to make it by default only 25 rows or make it adjustable for the user to choose? thank you!

I think that's a good idea: you can add a (not dynamic) number property to the datanode viewer control that allows to specify the page size (with a default of 25)

FredLL-Avaiga avatar Apr 22 '24 09:04 FredLL-Avaiga

@ioannastantzou Hello, Any news on this ticket?

jrobinAV avatar May 21 '24 08:05 jrobinAV

I'm sorry but it was so simple that I did it https://vscode.dev/github/Avaiga/taipy/blob/develop/frontend/taipy/src/DataNodeTable.tsx#L221

FredLL-Avaiga avatar May 21 '24 08:05 FredLL-Avaiga

OK, Great. Thank you. I let you close the ticket if needed.

jrobinAV avatar May 21 '24 11:05 jrobinAV

@FredLL-Avaiga Can we close the issue?

jrobinAV avatar Jun 03 '24 07:06 jrobinAV