taipy icon indicating copy to clipboard operation
taipy copied to clipboard

Color outline to indicate task execution state in scenario dag

Open AlexandreSajus opened this issue 1 year ago • 5 comments

Description

The scenario dag tasks could have outline colors to indicate in which state they are in when the scenario is submitted:

  • yellow means "pending"
  • orange means "running"
  • green means "ran"
  • red means "errored"
  • nothing means "not pending"

image

For example, here it would mean that clean_data has ran without issue, predict is currently running and evaluate will be ran afterwards.

This is very similar to a product an INCREDIBLE engineer made (or Zerve): flow_example

Solution Proposed

No response

Impact of Solution

No response

Additional Context

No response

Code of Conduct

  • [X] I have checked the existing issues.
  • [ ] I am willing to work on this issue (optional)

AlexandreSajus avatar Jun 11 '24 09:06 AlexandreSajus

This feature is interesting, but I believe we need to have to put it into a global context. We need to redefine global requirements for the dag.

Examples of questions that need to be answered globally:

  • The Orange box is a Task, not a job. There is no such thing as a Task state. You can have a Job status (pending, running, failed, etc.). A Task can be linked to multiple jobs, submitted by multiple users, eventually running simultaneously. Which Job should be chosen to represent in the dag?
  • What is the added value, and for who? The two big differences I can see with the tool you showed are the multi-user context and the targeted user. In your picture, you are in a development environment (IDE or notebook). There is only one user concerned, a developer. The UX is easy. The dag control is for a web application for multiple end-users. What is exactly the end user's need related to the job status?

jrobinAV avatar Jun 12 '24 09:06 jrobinAV

You wanted to add features to the DAG. Who was the target of these features?

I agree that we must know what this is for and, most importantly, for whom. In my opinion, it is a better UX to show the progress of your scenario inside the DAG. It is more visual.

We could provide a selector of submissions, and when a submission on the scenario is created, the DAG represents the submission being run.

FlorianJacta avatar Jun 12 '24 13:06 FlorianJacta

This is implemented. Can you comment on the current implementation?

FredLL-Avaiga avatar Jul 05 '24 15:07 FredLL-Avaiga

What is implemented? I just ran a scenario with develop and the dag does not have color outlines: image

AlexandreSajus avatar Jul 08 '24 09:07 AlexandreSajus

The tasks change colors when the corresponding job change status

FredLL-Avaiga avatar Jul 08 '24 10:07 FredLL-Avaiga

@FlorianJacta @AlexandreSajus Please come up with a (SHORT) code sample.

FabienLelaquais avatar Aug 12 '24 09:08 FabienLelaquais

I have not been able to reproduce the issue with different codes.

I guess it has to use the standalone mode for Core. I am closing this issue for now and we'll reopen if it comes back again.

FlorianJacta avatar Aug 14 '24 08:08 FlorianJacta