Soul Storm uses bonus_health instead of give_health (WAI?)

[luizsusin]

Describe the bug As Soul Storm description says, it gives a bonus to attack damage for X seconds at the expense of 3 hearts. However, it is using bonus_health instead of give_health, which only works with bonus hearts.

Expected behavior Not sure if it is WAI, but IMO it should use give_health instead based on the description.

Server Information (please complete the following information):

• Server: git-Purpur-1799 (MC: 1.19.2)
• EcoEnchants: 9.0.0-b37
• Eco: 6.42.0

[0ft3n]

give_health is a one-time triggered effect, and bonus_health does exactly same but permanently without a trigger, so using bonus_health here is correct

[Penumbrae]

@0ft3n it doesn't work with bonus_health as intended. By activating the spell, it tries to remove non-existent hearts (if you don't have extra ones). We've already fixed it, just do a quick test on the default one and this one: https://pastebin.com/ucYmuHLG. They behave in a completely different way.

[WillFP]

It's meant to reduce your max health temporarily, bonus_health is the right effect for that?

[Penumbrae]

@WillFP I'm sorry for the quality, but here it goes. I'm using the alt_click trigger for both of the items, the first one is the Soul Storm that I've made. The second one is the Soul Storm that comes by default: https://imgur.com/a/rRvnjLe