EcoEnchants icon indicating copy to clipboard operation
EcoEnchants copied to clipboard

Missing "Lore"

Open AlexanderMoebius opened this issue 2 years ago • 9 comments

Describe the bug Some items are enchanted and the enchantment work but there is no information in the lore, that the item is enchanted. The enchantment glow is on the items. So the enchantments are there but not visible. It would be sufficient to add checks or commands to renew the lore

To Reproduce Steps to reproduce the behavior:

  1. Use latest EcoEnchants v8
  2. Wait for the bug
  3. Upgrade to v9 and rearrange the same enchantments

Expected behavior The lore should display the enchantments

Screenshots Bildschirmfoto 2022-09-19 um 12 09 09

Server Information (please complete the following information):

  • Paper version git-Paper-153 (MC: 1.19.2)
  • eco-6.41.1
  • EcoEnchants v9.0.0-b27

AlexanderMoebius avatar Sep 19 '22 10:09 AlexanderMoebius

Did you check if hide enchants is set?

MillionthOdin16 avatar Sep 23 '22 04:09 MillionthOdin16

Did you check if hide enchants is set?

Yes, now I checked and the ItemFlag "HideEnchants" is set. So for EcoEnchants this will be an easy fix with just unhide all items with (eco) enchants on it.

Not for all because this would break other items where hideenchants is intended

AlexanderMoebius avatar Sep 24 '22 13:09 AlexanderMoebius

This commit in eco should have resolved this issue https://github.com/Auxilor/eco/commit/82d269daf11876dd6722e130562fb6196210b53a

MillionthOdin16 avatar Sep 26 '22 21:09 MillionthOdin16

Also with current eco the enchants stay hidden. Or is there an event that needs to be triggered to display it correctly?

AlexanderMoebius avatar Sep 27 '22 10:09 AlexanderMoebius

Can confirm that the update did not resolve the issue. I'll talk to aux

On Tue, Sep 27, 2022, 06:09 Alexander Möbius @.***> wrote:

Also with current eco the enchants stay hidden. Or is there an event that needs to be triggered to display it correctly?

— Reply to this email directly, view it on GitHub https://github.com/Auxilor/EcoEnchants/issues/299#issuecomment-1259282131, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYMC3ADUHWDBINLQI667YKTWALBUXANCNFSM6AAAAAAQP6VP3U . You are receiving this because you commented.Message ID: @.***>

MillionthOdin16 avatar Sep 27 '22 13:09 MillionthOdin16

Recommended fix from aux in discord is to set packet frames to false in eco config.yml he said he will implement proper fix eventually

MillionthOdin16 avatar Sep 30 '22 19:09 MillionthOdin16

This also does not work. Even with the most current eco and EcoEnchants.

It is not a problem with packet manipulation but with the item flag hideEnchants in the itemStack ItemMeta.

AlexanderMoebius avatar Oct 03 '22 20:10 AlexanderMoebius

Aux says to disable packet frames in eco config.yml until it gets a proper fix

On Mon, Oct 3, 2022, 16:07 Alexander Möbius @.***> wrote:

This also does not work. Even with the most current eco and EcoEnchants.

It is not a problem with packet manipulation but with the item flag hideEnchants in the itemStack ItemMeta.

— Reply to this email directly, view it on GitHub https://github.com/Auxilor/EcoEnchants/issues/299#issuecomment-1265969715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYMC3AH7ABUHRCA5U6SEJTDWBM4INANCNFSM6AAAAAAQP6VP3U . You are receiving this because you commented.Message ID: @.***>

MillionthOdin16 avatar Oct 03 '22 20:10 MillionthOdin16

Is there a way to easily check on an item if there is an EcoEnchant on it so I can make the enchant visible by an own plugin?

Or will a fix be released soon?

AlexanderMoebius avatar Oct 15 '22 09:10 AlexanderMoebius