zoninator icon indicating copy to clipboard operation
zoninator copied to clipboard

Adding filter to $this->default_post_types

Open ryanwelcher opened this issue 10 years ago • 4 comments

Adding a filter to allow other post types to be used

ryanwelcher avatar May 16 '15 22:05 ryanwelcher

Since the root issue is that the default_post_types property doesn't updated when additional post_types are added/removed from zoninator, we should fix that instead. Otherwise, we make adding post_type support even harder (you have to call add_post_type_support AND filter this AND ...).

mjangda avatar Jun 11 '15 04:06 mjangda

Admittedly, this filter makes it pretty easy to add post type support but goes against the typical WordPress-way of adding post_type support. I think I'll need to think on it or additional feedback/viewpoints :)

mjangda avatar Jun 11 '15 04:06 mjangda

:+1: to @mjangda I agree on that

bcampeau avatar Jun 11 '15 05:06 bcampeau

Thanks for your feedback! I have taken a different approach based on your comments and issued a new pull request on a different branch - #34

ryanwelcher avatar Jun 13 '15 03:06 ryanwelcher