wp-memcached
wp-memcached copied to clipboard
Documentation & PHPCS
I ran thru the plugin trying to add docblocks and some basic cleanup based on PHPCS using WordPress Standards.
I should note these are the remaining issues reported:
------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 13 WARNINGS AFFECTING 19 LINES
------------------------------------------------------------------------------------------------------
1 | ERROR | Class file names should be based on the class name with "class-" prepended. Expected
| | class-wp-object-cache.php, but found object-cache.php.
130 | ERROR | Overriding WordPress globals is prohibited
160 | WARNING | Found: ==. Use strict comparisons (=== or !==).
354 | WARNING | Not using strict comparison for in_array; supply true for third argument.
473 | WARNING | Not using strict comparison for in_array; supply true for third argument.
548 | WARNING | Not using strict comparison for in_array; supply true for third argument.
554 | WARNING | Not using strict comparison for in_array; supply true for third argument.
555 | ERROR | Assignments must be the first block of code on a line
586 | WARNING | This comment is 56% valid code; is this commented out code?
605 | WARNING | Not using strict comparison for in_array; supply true for third argument.
640 | WARNING | Not using strict comparison for array_search; supply true for third argument.
681 | WARNING | Not using strict comparison for array_search; supply true for third argument.
744 | WARNING | Not using strict comparison for in_array; supply true for third argument.
810 | ERROR | Expected next thing to be an escaping function (see Codex for 'Data Validation'),
| | not '"<strong>$stat</strong> $n"'
818 | WARNING | Processing form data without nonce verification.
820 | ERROR | Expected next thing to be an escaping function (see Codex for 'Data Validation'),
| | not 'add_query_arg'
823 | ERROR | Expected next thing to be an escaping function (see Codex for 'Data Validation'),
| | not '"<h4>$group commands</h4>"'
832 | WARNING | print_r() found. Debug code should not normally be used in production.
914 | WARNING | Found: ==. Use strict comparisons (=== or !==).
https://codeclimate.com/github/bhubbard/wp-memcached/object-cache.php#
have this commit ever been merged? if not, have you that complete file still remaint somewhere? your link is dead.