wp-e2e-tests icon indicating copy to clipboard operation
wp-e2e-tests copied to clipboard

Add tests to guard against reconciliation errors (themes)

Open ockham opened this issue 8 years ago • 3 comments

Calypso's /themes and /theme routes, when visited by a logged-out user, make use of Server-Side Rendering (SSR) for SEO and performance benefits. The latter is hampered by reconciliation errors that tend to sneak in easily, see e.g. https://github.com/Automattic/wp-calypso/issues/13376. It'd be nice to guard against this kind of error with an e2e test.

ockham avatar Apr 25 '17 15:04 ockham

I believe @rachelmcr has added a sign up test for a premium theme purchase from a signed out /themes start, are we able to close this?

alisterscott avatar Mar 19 '18 05:03 alisterscott

Hmm, this isn't really about any flows (such as purchase etc) but rather about checking for the presence of a console error complaining about a mismatch between server-rendered and client-rendered layouts, right when landing on an SSR'd page.

Automattic/wp-calypso#13376 illustrates what these normally look like:

To repro:

  • Run Calypso locally (error is hidden in production)
  • In an incognito window, land at http://calypso.localhost:3000/themes
  • Check the console:

image

(Error messages have changed per React 16 IIRC.)

ockham avatar Mar 28 '18 15:03 ockham

Thanks @ockham for the context

I'll keep this open to see what we can add for this

alisterscott avatar Mar 29 '18 04:03 alisterscott