wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Login: only first 2FA button is styled correctly

Open bluefuton opened this issue 1 year ago • 1 comments

Quick summary

In the 2FA login step on WordPress.com, only the first button shown has the correct styles. The second one that appears ("Continue with backup code") looks broken.

In desktop Safari:

Screenshot 2024-07-01 at 09 56 39

Steps to reproduce

  1. Start at https://wordpress.com/log-in and login with an account that has 2FA enabled
  2. Check out the buttons on the following 2FA step (https://wordpress.com/log-in/push)

What you expected to happen

The buttons should be styled consistently.

What actually happened

The second button ("Continue with backup code") looks broken.

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

bluefuton avatar Jul 01 '24 02:07 bluefuton

I noticed that the button styles are targeted to :first-of-type:

Screenshot 2024-07-01 at 14 48 16

bluefuton avatar Jul 01 '24 02:07 bluefuton

Unable to triage as I have a Security Key (not 2FA) but adding to the One Board for someone to pick up

jordesign avatar Jan 13 '25 05:01 jordesign

This is how I see it on my end, but it looks like the one above also involves a WordPress app connected account.

Image

I'm unable to replicate this anymore, however, @bluefuton if you see this again, please reopen the issue and ping me.

Robertght avatar Jan 13 '25 12:01 Robertght

Hi @Robertght - still broken for me. Tested in both Firefox and Chrome.

This is at https://wordpress.com/log-in/push:

Image Image

I'm using a non-a8c user account that must have been associated with the Jetpack mobile app somewhere along the way.

Let me know if I can help you reproduce it.

bluefuton avatar Jan 13 '25 21:01 bluefuton

Reproduction steps: With a non-a8c account:

  • Login to the Jetpack App
  • Via Web, setup 2FA via TOTP app
  • Ensure no Security keys or other auth things are set (No SMS, keys, etc)
  • Logout on web
  • Attempt login, duplicate issue.

I noticed that the button styles are targeted to :first-of-type:

This was introduced with #75414, looking at the screenshots there, that change appears to have been intended and valid.

The UI however has changed since then, and whilst I can't find the PR that changed it, it seems that relaxing this rule is relatively safe. PR incoming.

dd32 avatar Jan 21 '25 03:01 dd32