wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

A4A > Marketplace: Fix the hosting card overlap issues

Open yashwin opened this issue 1 year ago • 4 comments

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/729

Proposed Changes

This PR fixes the hosting card overlap issues.

Testing Instructions

  • Open A4A live link
  • Visit the Marketplace > Verify the hosting cards don't overlap at 1280px when the agency has a non-A4A pressable license, and the button text is changed to Manage in Pressable
Screenshot 2024-06-28 at 3 30 00 PM

When in the German language:

@jeffgolenski:

Note: The line items are not aligned. Another solution could be to change the button text to Explore WordPress.com from Explore WordPress.com plans`

Screenshot 2024-06-28 at 3 27 45 PM

Pre-merge Checklist

  • [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
  • [ ] Have you written new tests for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [ ] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

yashwin avatar Jun 28 '24 10:06 yashwin

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a/marketplace-hosting-card-overflow on your sandbox.

matticbot avatar Jun 28 '24 10:06 matticbot

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~35 bytes removed 📉 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-marketplace       -174 B  (-0.0%)      -35 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Jun 28 '24 10:06 matticbot

I cannot see the Pressable card...

cleacos avatar Jun 28 '24 13:06 cleacos

Thanks @yashwin! As suggested let's also remove the word "plans" from both of those CTAS. They should read "Explore WordPress.com" and "Explore Pressable" where applicable.

jeffgolenski avatar Jul 01 '24 12:07 jeffgolenski

I cannot see the Pressable card...

@cleacos: Could you please share the full screenshot? I hope you are not trying it on Refer products mode

As suggested let's also remove the word "plans" from both of those CTAS. They should read "Explore WordPress.com" and "Explore Pressable" where applicable.

Thanks for the confirmation, @jeffgolenski! I have made the adjustments.

yashwin avatar Jul 02 '24 03:07 yashwin