wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Entrepreneur Signup: Add trial acknowledgement step.

Open yansern opened this issue 1 year ago • 2 comments

Related to #

Proposed Changes

  • Add a trial acknowledgement page after segmentation survey step.

Why are these changes being made?

  • Email verification is required for new users. Having the trial acknowledgement page gives user a smoother experience.

Testing Instructions

  • Open incognito window.
  • Go to /setup/entrepreneur.
  • Create a new account.
  • After segmentation survey step, you should see the trial acknowledgement step.
    • Detour: Press back, you should go back to page 2 of the segmentation survey step.
      • Known issue: the answers have been cleared at this point. (ignore it for now)
  • Check your inbox, you should receive an email verification link.
    • Click on the verification link.
    • Known issue: You currently will land on the Sites page, we'll address that separately in a WPCOM patch.
  • Go back to the original tab where the trial acknowledgment step.
    • The button should be now enabled, and you can continue creating the site.
image

Pre-merge Checklist

  • [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
  • [ ] Have you written new tests for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [ ] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

yansern avatar May 24 '24 13:05 yansern

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~1 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +29 B  (+0.0%)       -1 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~494 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
import-hosted-site-flow                +2419 B  (+0.3%)     +326 B  (+0.1%)
import-flow                            +2419 B  (+0.1%)     +326 B  (+0.0%)
themes                                  +271 B  (+0.0%)      +23 B  (+0.0%)
plugins                                 +271 B  (+0.0%)      +22 B  (+0.0%)
hosting                                 +271 B  (+0.0%)      +20 B  (+0.0%)
jetpack-cloud-plugin-management         +242 B  (+0.0%)      +14 B  (+0.0%)
entrepreneur-flow                       +151 B  (+0.3%)      +64 B  (+0.8%)
theme                                    +29 B  (+0.0%)       +9 B  (+0.0%)
sites-dashboard                          +29 B  (+0.0%)       +6 B  (+0.0%)
site-purchases                           +29 B  (+0.0%)       +8 B  (+0.0%)
site-monitoring                          +29 B  (+0.0%)       +6 B  (+0.0%)
site-blocks                              +29 B  (+0.0%)       +9 B  (+0.0%)
signup                                   +29 B  (+0.0%)       +8 B  (+0.0%)
settings                                 +29 B  (+0.0%)       +8 B  (+0.0%)
security                                 +29 B  (+0.0%)       +9 B  (+0.0%)
purchases                                +29 B  (+0.0%)       +9 B  (+0.0%)
privacy                                  +29 B  (+0.0%)       +9 B  (+0.0%)
plans                                    +29 B  (+0.0%)       +7 B  (+0.0%)
notification-settings                    +29 B  (+0.0%)       +9 B  (+0.0%)
me                                       +29 B  (+0.0%)       +9 B  (+0.0%)
marketplace                              +29 B  (+0.0%)       +9 B  (+0.0%)
jetpack-connect                          +29 B  (+0.0%)       +7 B  (+0.0%)
jetpack-cloud-pricing                    +29 B  (+0.0%)       +7 B  (+0.0%)
jetpack-cloud-features-comparison        +29 B  (+0.0%)      +10 B  (+0.0%)
jetpack-app                              +29 B  (+0.0%)       +9 B  (+0.0%)
home                                     +29 B  (+0.0%)       +9 B  (+0.0%)
help                                     +29 B  (+0.0%)       +9 B  (+0.0%)
github-deployments                       +29 B  (+0.0%)       +6 B  (+0.0%)
email                                    +29 B  (+0.0%)       +8 B  (+0.0%)
domains                                  +29 B  (+0.0%)       +8 B  (+0.0%)
developer                                +29 B  (+0.0%)       +9 B  (+0.0%)
dev-tools-promo                          +29 B  (+0.0%)       +6 B  (+0.0%)
checkout                                 +29 B  (+0.0%)       +8 B  (+0.0%)
account-close                            +29 B  (+0.0%)       +9 B  (+0.0%)
account                                  +29 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~59 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-purchase-modal-wrapper                                                       +29 B  (+0.0%)       +8 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +29 B  (+0.0%)       +9 B  (+0.0%)
async-load-design-blocks                                                                +29 B  (+0.0%)       +9 B  (+0.0%)
async-load-design                                                                       +29 B  (+0.0%)       +9 B  (+0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice                        +29 B  (+0.1%)       +7 B  (+0.1%)
async-load-calypso-layout-masterbar-checkout-tsx                                        +29 B  (+0.0%)       +8 B  (+0.0%)
async-load-calypso-layout-masterbar-checkout                                            +29 B  (+0.0%)       +9 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                                         +29 B  (+0.0%)       +9 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar May 24 '24 13:05 matticbot

I always get false from isVerified and hasUser.

@ivan-ottinger This is the issue I notice from your local Calypso and @JuanLucha too. After a user is created, the auth is not transferred back to the local Calypso for some reason. You both probably will run into the same error with the hosting signup flow too, so you both always have to test on production environment.

@mashikag I think your local Calypso doesn't have the same issue. Maybe you could try.

If there's time maybe we need to look into why yours and @JuanLucha couldn't get your local Calypso's auth updated after login/signup.

yansern avatar May 24 '24 15:05 yansern

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/entrepreneur-trial-page on your sandbox.

matticbot avatar May 27 '24 09:05 matticbot

If there's time maybe we need to look into why yours and @JuanLucha couldn't get your local Calypso's auth updated after login/signup.

Yeah, it's odd. I suspect it could be something with the local server step (PCYsg-5YE-p2). 🤔

I will try to revert the setup changes that I made as a part of that server setup.

ivan-ottinger avatar May 27 '24 11:05 ivan-ottinger

I will try to revert the setup changes that I made as a part of that server setup.

Hm. When testing the changes in trunk (still local Calypso), everything is looking good now.

Markup on 2024-05-27 at 13:52:18

I didn't make any changes at the end. So will see if I encounter similar issue in future PRs and will investigate further.

ivan-ottinger avatar May 27 '24 11:05 ivan-ottinger