wp-calypso
wp-calypso copied to clipboard
Odie clean up
Proposed Changes
Fixes and cleanup!
Testing Instructions
The feedback is going to be improved in the next PR's this one just settles the base. Test that you can keep chatting and you can add feedback.
The issue (that still exist before this patch) is that the cache needs to be updated with the user interactions, othwesei refreshing the screen takes a lot of time to see the latest interactions due to the get_chat endpoint.
Pre-merge Checklist
- [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
- [ ] Have you written new tests for your changes?
- [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
- [ ] Have you checked for TypeScript, React or other console errors?
- [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
- [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:
Async-loaded Components (~82 bytes added 📈 [gzipped])
name parsed_size gzip_size
async-load-automattic-help-center +133 B (+0.0%) +82 B (+0.1%)
React components that are loaded lazily, when a certain part of UI is displayed for the first time.
Legend
What is parsed and gzip size?
Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.
Generated by performance advisor bot at iscalypsofastyet.com.
This PR modifies the release build for the following Calypso Apps:
For info about this notification, see here: PCYsg-OT6-p2
- editing-toolkit
To test WordPress.com changes, run install-plugin.sh $pluginSlug prismiwi2015/odie-fixes-cleanup
on your sandbox.