wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard
verified publisher icon Automattic

Automattic for Agencies: Add Licenses page layout with search & filter

Open yashwin opened this issue 1 year ago • 3 comments

This PR is built on top of https://github.com/Automattic/wp-calypso/pull/87759

Resolves https://github.com/Automattic/jetpack-genesis/issues/240 Resolves https://github.com/Automattic/jetpack-genesis/issues/247 Resolves https://github.com/Automattic/jetpack-genesis/issues/248

Screenshot 2024-02-23 at 11 43 47 AM

Proposed Changes

This PR adds:

  • Layout for the Licenses page
  • Search
  • Filters

Testing Instructions

NOTE: Please ignore any color difference for now. We will fix it later.

  • Switch to the branch git checkout add/a4a-licenses-layout-with-search-filter.
  • Start the server by running yarn start-a8c-for-agencies.
  • Click the Licenses menu item > Verify that you can see the Licenses page as shown above.
  • Verify that all the filters redirect you to appropriate links.
  • Verify that searching for something appends the URL with the same text.
  • Click the Issue New License button > Verify that you are redirected to /marketplace

Pre-merge Checklist

  • [x] Has the general commit checklist been followed? (PCYsg-hS-p2)
  • [ ] https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [x] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

yashwin avatar Feb 23 '24 06:02 yashwin

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-98941
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-98941&env=jetpack

github-actions[bot] avatar Feb 23 '24 06:02 github-actions[bot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~39 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +356 B  (+0.0%)      +55 B  (+0.0%)
entry-main                  +356 B  (+0.0%)      +57 B  (+0.0%)
entry-subscriptions         +338 B  (+0.0%)      +73 B  (+0.0%)
entry-login                 +338 B  (+0.0%)      +73 B  (+0.0%)
entry-domains-landing       +338 B  (+0.1%)      +73 B  (+0.0%)
entry-browsehappy           +338 B  (+0.2%)      +73 B  (+0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6697 bytes added 📈 [gzipped])

name                             parsed_size            gzip_size
a8c-for-agencies-purchases          +59812 B  (+31.3%)   +18161 B  (+29.8%)
a8c-for-agencies-marketplace         +1683 B   (+0.4%)     +241 B   (+0.2%)
settings-jetpack                      +300 B   (+0.1%)      +72 B   (+0.0%)
home                                  -230 B   (-0.0%)     -450 B   (-0.1%)
jetpack-search                        -103 B   (-0.0%)     -111 B   (-0.1%)
site-purchases                         +69 B   (+0.0%)      +27 B   (+0.0%)
purchases                              +69 B   (+0.0%)      +27 B   (+0.0%)
domains                                +56 B   (+0.0%)       -4 B   (-0.0%)
activity                               +52 B   (+0.0%)      -14 B   (-0.0%)
scan                                   +39 B   (+0.0%)     +180 B   (+0.1%)
backup                                 +39 B   (+0.0%)      +28 B   (+0.0%)
themes                                 -34 B   (-0.0%)       -4 B   (-0.0%)
settings                               -34 B   (-0.0%)       -3 B   (-0.0%)
plugins                                -34 B   (-0.0%)       -4 B   (-0.0%)
plans                                  -34 B   (-0.0%)       -3 B   (-0.0%)
jetpack-cloud-plugin-management        -34 B   (-0.0%)       -4 B   (-0.0%)
jetpack-cloud-partner-portal           -34 B   (-0.0%)      -12 B   (-0.0%)
hosting                                -34 B   (-0.0%)       -4 B   (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~3 bytes removed 📉 [gzipped])

name               parsed_size           gzip_size
async-load-design        -34 B  (-0.0%)       -3 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Feb 23 '24 06:02 matticbot

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a-licenses-layout-with-search-filter on your sandbox.

matticbot avatar Feb 23 '24 06:02 matticbot