wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Add auto-renew coupon details to purchase meta

Open aneeshd16 opened this issue 1 year ago • 3 comments

Fixes https://github.com/Automattic/martech/issues/2739

Proposed Changes

  • Shows auto-renew coupon details if it exists on the purchase object. image

Testing Instructions

  • Follow test instructions in D139122-code

Pre-merge Checklist

  • [ ] Has the general commit checklist been followed? (PCYsg-hS-p2)
  • [ ] https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [ ] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • [ ] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

aneeshd16 avatar Feb 21 '24 13:02 aneeshd16

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • editing-toolkit
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/purchase-detail-auto-renew-coupon on your sandbox.

matticbot avatar Feb 21 '24 13:02 matticbot

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~404 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
site-purchases                          +643 B  (+0.0%)     +199 B  (+0.0%)
purchases                               +643 B  (+0.0%)     +199 B  (+0.0%)
woocommerce-installation                +127 B  (+0.0%)      +34 B  (+0.0%)
woocommerce                             +127 B  (+0.0%)      +34 B  (+0.0%)
update-design-flow                      +127 B  (+0.0%)      +41 B  (+0.0%)
themes                                  +127 B  (+0.0%)      +34 B  (+0.0%)
theme                                   +127 B  (+0.0%)      +34 B  (+0.0%)
subscribers                             +127 B  (+0.0%)      +34 B  (+0.0%)
stats                                   +127 B  (+0.0%)      +34 B  (+0.0%)
sites-dashboard                         +127 B  (+0.0%)      +34 B  (+0.0%)
site-monitoring                         +127 B  (+0.0%)      +34 B  (+0.0%)
settings-writing                        +127 B  (+0.0%)      +34 B  (+0.0%)
settings-security                       +127 B  (+0.0%)      +34 B  (+0.0%)
settings-reading                        +127 B  (+0.0%)      +34 B  (+0.0%)
settings-podcast                        +127 B  (+0.0%)      +34 B  (+0.0%)
settings-performance                    +127 B  (+0.0%)      +34 B  (+0.0%)
settings-newsletter                     +127 B  (+0.0%)      +34 B  (+0.0%)
settings-jetpack                        +127 B  (+0.0%)      +34 B  (+0.0%)
settings-discussion                     +127 B  (+0.0%)      +34 B  (+0.0%)
settings                                +127 B  (+0.0%)      +34 B  (+0.0%)
scan                                    +127 B  (+0.0%)      +34 B  (+0.0%)
promote-post-i2                         +127 B  (+0.0%)      +34 B  (+0.0%)
preview                                 +127 B  (+0.0%)      +34 B  (+0.0%)
posts-custom                            +127 B  (+0.0%)      +34 B  (+0.0%)
posts                                   +127 B  (+0.0%)      +34 B  (+0.0%)
plugins                                 +127 B  (+0.0%)      +34 B  (+0.0%)
plans                                   +127 B  (+0.0%)      +34 B  (+0.0%)
people                                  +127 B  (+0.0%)      +34 B  (+0.0%)
pages                                   +127 B  (+0.0%)      +34 B  (+0.0%)
migrate                                 +127 B  (+0.0%)      +34 B  (+0.0%)
media                                   +127 B  (+0.0%)      +34 B  (+0.0%)
marketplace                             +127 B  (+0.0%)      +34 B  (+0.0%)
marketing                               +127 B  (+0.0%)      +34 B  (+0.0%)
link-in-bio-tld-flow                    +127 B  (+0.0%)      +41 B  (+0.0%)
jetpack-social                          +127 B  (+0.0%)      +34 B  (+0.0%)
jetpack-search                          +127 B  (+0.0%)      +34 B  (+0.0%)
jetpack-connect                         +127 B  (+0.0%)      +34 B  (+0.0%)
jetpack-cloud-settings                  +127 B  (+0.0%)      +34 B  (+0.0%)
jetpack-cloud-pricing                   +127 B  (+0.0%)      +34 B  (+0.0%)
jetpack-cloud-plugin-management         +127 B  (+0.0%)      +34 B  (+0.0%)
jetpack-cloud-overview                  +127 B  (+0.0%)      +34 B  (+0.0%)
jetpack-cloud-features-comparison       +127 B  (+0.0%)      +34 B  (+0.0%)
jetpack-cloud                           +127 B  (+0.0%)      +34 B  (+0.0%)
jetpack-app                             +127 B  (+0.0%)      +35 B  (+0.0%)
import-hosted-site-flow                 +127 B  (+0.0%)      +34 B  (+0.0%)
import-flow                             +127 B  (+0.0%)      +34 B  (+0.0%)
import                                  +127 B  (+0.0%)      +34 B  (+0.0%)
hosting                                 +127 B  (+0.0%)      +34 B  (+0.0%)
home                                    +127 B  (+0.0%)      +34 B  (+0.0%)
help                                    +127 B  (+0.0%)      +43 B  (+0.0%)
gutenberg-editor                        +127 B  (+0.0%)      +34 B  (+0.0%)
google-my-business                      +127 B  (+0.0%)      +34 B  (+0.0%)
github-deployments                      +127 B  (+0.0%)      +34 B  (+0.0%)
export                                  +127 B  (+0.0%)      +34 B  (+0.0%)
email                                   +127 B  (+0.0%)      +34 B  (+0.0%)
earn                                    +127 B  (+0.0%)      +34 B  (+0.0%)
domains                                 +127 B  (+0.0%)      +34 B  (+0.0%)
customize                               +127 B  (+0.0%)      +34 B  (+0.0%)
copy-site-flow                          +127 B  (+0.0%)      +47 B  (+0.0%)
concierge                               +127 B  (+0.0%)      +34 B  (+0.0%)
comments                                +127 B  (+0.0%)      +34 B  (+0.0%)
checkout                                +127 B  (+0.0%)      +34 B  (+0.0%)
backup                                  +127 B  (+0.0%)      +34 B  (+0.0%)
add-ons                                 +127 B  (+0.0%)      +34 B  (+0.0%)
activity                                +127 B  (+0.0%)      +34 B  (+0.0%)
account-close                           +127 B  (+0.0%)      +39 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~273 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-theme-selection               +127 B  (+0.0%)      +41 B  (+0.0%)
async-load-signup-steps-plans-theme-preselected       +127 B  (+0.0%)      +40 B  (+0.0%)
async-load-signup-steps-plans                         +127 B  (+0.0%)      +41 B  (+0.0%)
async-load-design-blocks                              +127 B  (+0.0%)      +35 B  (+0.0%)
async-load-design                                     +127 B  (+0.0%)      +34 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal            +127 B  (+0.0%)      +40 B  (+0.0%)
async-load-automattic-help-center                     +127 B  (+0.0%)      +42 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Feb 21 '24 13:02 matticbot

Thanks for the review and for testing this, @oswian!

It would be nice to add tests for PurchaseMetaAutoRenewCouponDetail

Done via https://github.com/Automattic/wp-calypso/pull/87715/commits/c6c0a26d63e33d8537d7c8ffad4ec85e1d9c9665!

aneeshd16 avatar Feb 29 '24 07:02 aneeshd16

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/11516111

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @aneeshd16 for including a screenshot in the description! This is really helpful for our translators.

a8ci18n avatar Mar 01 '24 06:03 a8ci18n

Translation for this Pull Request has now been finished.

a8ci18n avatar Mar 04 '24 00:03 a8ci18n