Automattic
Storage add-on: A user can't buy the 50G add-on and then buy the 100G add-on
Quick summary
This issue is broken out from the auditing in https://github.com/Automattic/wp-calypso/issues/85773.
As shown here, my test Business site owning a 50G add-on can't buy the 100G add-on since it's absent. In /plans, it's even more confusing since I can select it but it will show me "Contact Support"
It should be available since the maximum storage is 200G. From a quick glance of the code, the way exceedsSiteStorageLimits computed is wrong.
Steps to reproduce
- Create a test site on the Creator(Business) plan.
- Purchase the 50G add-on
- Access
/add-ons
What you expected to happen
I'd see the 100G add-on available.
What actually happened
The 100G add-on doesn't show.
Impact
Some (< 50%)
Available workarounds?
No but the platform is still usable.
Platform (Simple and/or Atomic)
No response
Logs or notes
No response
@southp as far as I checked this will also fail on checkout, so it's actually correctly removed in the UI. Either the site cannot upgrade to another 100GB or only a single storage add-on purchase is permissible.
I think/recall part of my testing the difference between the 200GB limit and a Creator site with extra 50GB was 93 and not 100. Not sure where the other 7 came from - which would make for additional 100GB purchase violate the 200 limit. We need to check the backend.
I think the issue is a bit different now, and it depends on whether the site is Simple or Atomic, and whether the admin interface is set to Default or Classic.
Simple sites – Default admin interface
- Can I purchase storage from the Plans page? ❌
- Is the "Upgrades > Add-ons" menu available? ✅
- Can I purchase storage from the Add-ons page? ✅
- The "Needs more storage?" link in the Hosting overview page opens the Plans page, where I cannot purchase extra storage ❌
| Plans page | Add-ons page | Hosting overview page |
|---|---|---|
Simple sites – Classic admin interface
- Can I purchase storage from the Plans page? ❌
- Is the "Hosting > Add-ons" menu available? ✅
- Can I purchase storage from the Add-ons page? ✅
- The "Needs more storage?" link in the Hosting overview page opens the Plans page, where I cannot purchase extra storage ❌
| Plans page | Add-ons page | Hosting overview page |
|---|---|---|
Atomic sites – Default admin interface
- Can I purchase storage from the Plans page? ✅
- Is the "Upgrades > Add-ons" menu available? ❌
- Can I purchase storage from the Add-ons page? ✅
- The "Needs more storage?" link in the Hosting overview page opens the Add-ons page, which is not accessible from any menu (but I can at least purchase extra storage here) ⚠
| Plans page | Add-ons page | Hosting overview page |
|---|---|---|
Atomic sites – Classic admin interface
- Can I purchase storage from the Plans page? ✅
- Is the "Hosting > Add-ons" menu available? ✅
- Can I purchase storage from the Add-ons page? ✅
- The "Needs more storage?" link in the Hosting overview page opens the Add-ons page, where I cannot purchase extra storage ✅
| Plans page | Add-ons page | Hosting overview page |
|---|---|---|
The experience is quite inconsistent 🤯
Ideally:
- Extra storage should be purchased in the same places (Plans, or Add-ons, or both) across all scenarios
- The "Needs more storage?" link should like to the same page always
- The Add-ons menu should be visible at all cases
cc @Automattic/martech @Automattic/lego @Automattic/shilling
Opened D164593-code and https://github.com/Automattic/wp-calypso/pull/95678 which fixes this issue.
I also opened a nice to have change in /plans page that adds the addon dropdown for Personal and Premium plans: https://github.com/Automattic/wp-calypso/pull/95677 - we can skip this one if the addons shouldn't appear for premium and personal plans.
@BogdanUngureanu I'm moving this back to "In Progress" since I think some more changes are still needed for D164593-code to fix the tests.
It also seems that https://github.com/Automattic/wp-calypso/pull/95677 should be abandoned?
Feel free to change the status to "Needs Review" once everything is ready.