wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Classic Themes: Duotone filter not applied on live site

Open cuemarie opened this issue 2 years ago β€’ 16 comments

2023-08-31 - reported anew in /gutenberg repo here: https://github.com/WordPress/gutenberg/issues/54099

Quick summary

On sites using a classic theme, Duotone filters apply in the post editor, but don't appear on the live site

Steps to reproduce

  1. Activate a classic theme like Twenty Twenty
  2. Open a new post and add an image block
  3. Add a duotone filter
  4. Save and view the post

What you expected to happen

The duotone filter to appear just like in the editor.

What actually happened

No duotone is applied.

Editor Markup on 2023-06-20 at 10:37:04

Live Site Markup on 2023-06-20 at 10:38:26

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Tested on Atomic site, Firefox browser

Duotone worked as expected on same site using theme TT3

cuemarie avatar Jun 20 '23 17:06 cuemarie

Recent report from #74357 :

  • Chat: 6427916-zd-woothemes (Libre 2 theme)
  • Follow Up Ticket: 6428606-zd-woothemes

cuemarie avatar Jun 20 '23 17:06 cuemarie

Support References

This comment is automatically generated. Please do not edit it.

  • [ ] 6427916-zen
  • [ ] 6428606-zen
  • [ ] 6473910-zen
  • [ ] 6752520-zen
  • [ ] 6259701-zen
  • [ ] 6199292-zen
  • [ ] 6252844-zen
  • [ ] 6545304-zen
  • [ ] 7123721-zen
  • [ ] 7225527-zen
  • [ ] 7197512-zen
  • [ ] 7293087-zen
  • [ ] 7714741-zen
  • [ ] 7814855-zen

github-actions[bot] avatar Jun 20 '23 17:06 github-actions[bot]

πŸ“Œ SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

πŸ“Œ FINDINGS/SCREENSHOTS/VIDEO

  • Replicated on simple, AT, and outside of WordPress.com. Also noticed that if I set up an image with Duotone on an FSE theme, then switch the theme to a Classic theme, the duotone I set up is lost. I have to set it up again, but this time it doesn't apply to the live site.

Screenshots/Recordings

Duotone settings while on FSE theme TT3:

JCfxZg.png

Returning to my post after switching to theme Twenty Twenty:

https://github.com/Automattic/wp-calypso/assets/27249804/18bf0a95-d8aa-473b-95b3-3caa9e395d87

Atomic Site:

  • Gutenberg: v16.0.0
  • Editing Toolkit: 3.68851

Simple site:

  • Gutenberg: v16.0.0
  • Editing Toolkit: 3.68851
  • WP AMP: 2.0.5
  • CoBlocks: 2.18.1-simple-rev.4

Self-Hosted:

Markup on 2023-06-20 at 10:56:06

Markup on 2023-06-20 at 10:56:36

Gutenberg v16.0.0 and no other plugins

πŸ“Œ ACTIONS

  • Assigned to Non-Urgent
  • Added to β€˜HE Cross-repo Watchlist’ project board

πŸ“Œ Message to Author

  • Looks like this may have been intentional, but Duotone can likely come back to Classic Themes, based on the discussion in this /gutenberg issue:
  • https://github.com/WordPress/gutenberg/issues/49293

cuemarie avatar Jun 20 '23 17:06 cuemarie

Another; 6473910-zd-woothemes

Greatdane avatar Jun 28 '23 03:06 Greatdane

Another report: 6752520-zd-a8c Morden theme.

Found these similar issues that it might be good to merge: https://github.com/Automattic/themes/issues/7054 https://github.com/Automattic/wp-calypso/issues/75805

jamiepalatnik avatar Aug 31 '23 15:08 jamiepalatnik

Nice finds, @jamiepalatnik , thank you!

πŸ“Œ ACTIONS

  • closed Automattic/themes#7054 and carried over customer reports
  • Retested and closed closed https://github.com/Automattic/wp-calypso/issues/75805 and carried over customer reports

cuemarie avatar Aug 31 '23 18:08 cuemarie

Customer reports from https://github.com/Automattic/themes/issues/7054 :

  • 6259701-zen [Dara]
  • 27843422-hc [Sequential]

cuemarie avatar Aug 31 '23 18:08 cuemarie

Customer Reports from #75805 :

  • 6199292-zen - Simple, Theme: Orvis
  • 37361778-hc - Atomic, Theme: Seedlet
  • 6252844-zen - Atomic, Theme: Seedlet

cuemarie avatar Aug 31 '23 21:08 cuemarie

Retested and can still replicate this on a self-hosted site with Gutenberg 16.5.1 active and theme Twenty Sixteen.

https://github.com/Automattic/wp-calypso/assets/27249804/0b477e2f-df7d-43e0-aebf-c2fb877414e4

cuemarie avatar Aug 31 '23 21:08 cuemarie

πŸ“Œ ACTIONS Reported this anew in /gutenberg, here:

  • https://github.com/WordPress/gutenberg/issues/54099

cuemarie avatar Aug 31 '23 22:08 cuemarie

Since this is still open, I'm adding this Ticket reference, as I don't see it added before: 6545304-zd-a8c 7123721-zd-a8c

janmckell avatar Oct 12 '23 20:10 janmckell

I ran into another example of this issue: 7225527-zd-a8c

ckmccoy2 avatar Oct 27 '23 17:10 ckmccoy2

Another example while using the Alves theme: 7197512-zd-a8c

ClassicRKR27 avatar Oct 30 '23 14:10 ClassicRKR27

Example here with Barnsbury theme: 7293087-zd-a8c

CodeAllNightNDay avatar Nov 09 '23 14:11 CodeAllNightNDay

https://github.com/WordPress/gutenberg/issues/54099 was just fixed last week, so this should resolve soon. Will need a retest to confirm.

cuemarie avatar Nov 30 '23 20:11 cuemarie

7714741-zen

mahfuzurwp avatar Feb 22 '24 16:02 mahfuzurwp

7814855-zen

tvolpert avatar Feb 29 '24 17:02 tvolpert