Checkout: New card option should be relabeled as "New credit or debit card" when the user has an existing card

[DavidRothstein]

What

In checkout, the option for adding a new credit or debit card should change from "Credit or debit card" to "New credit or debit card" (or similar) in the case where the user already has at least one other card on their account.

Why

It looks confusing the way it currently is, since it kind of implies that the existing payment methods the user has right above it aren't actually credit or debit cards...

How

It looks like this was proposed in the past (although with slightly different wording) at pbOQVh-kI-p2#comment-524 and https://github.com/Automattic/wp-calypso/pull/44271 although it doesn't seem to have been merged, and I'm not sure why. But we could look at that for inspiration on how to implement this.

[DavidRothstein]

Hm, I guess this doesn't just apply to checkout, but also to the page for adding or changing a payment method on an existing subscription. Although I think it is probably similar work to implement this in both places.

[michaeldcain]

From planning:

I think the original PR was lost to higher priority issues - not a specific decision not to make the change. This is still a good change to make. It sounds like we should pass whether or not we're in the "existing card" context down from useCreatePaymentMethods.

[jjchrisdiehl]

PR https://github.com/Automattic/wp-calypso/pull/87917

[github-actions[bot]]

Support References

This comment is automatically generated. Please do not edit it.

• [ ] pbOQVh-kI-p2#comment-524