wp-calypso
wp-calypso copied to clipboard
[Jetpack Pricing Page rework]: Switch over to PlanPrice and update styling
Proposed Changes
In the Lightbox component, we switch to the PlanPrice
component to have identical behaviour of price with the main page.
Testing Instructions
While proxied
- Use one method from
- Click on Jetpack Cloud live link below and wait for the redirect to complete, then go to
/pricing
-
OR run this PR locally
- download branch locally and run yarn start-jetpack-cloud`
- Goto http://jetpack.cloud.localhost:3000/pricing
- Click on Jetpack Cloud live link below and wait for the redirect to complete, then go to
- Look through product lightboxes by clicking the button
More about ...
and verify that prices are represented with the same values as on the main page (Especially ones with values without decimals).
Before | After |
---|---|
![]() |
![]() |
Pre-merge Checklist
- [ ] Have you written new tests for your changes?
- [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
- [ ] Have you checked for TypeScript, React or other console errors?
- [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
- [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
Related to # 0-as-1203030714907103/f
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1203030714907103
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:
Sections (~62 bytes removed 📉 [gzipped])
name parsed_size gzip_size
plans -77 B (-0.0%) -62 B (-0.0%)
jetpack-connect -77 B (-0.0%) -62 B (-0.0%)
jetpack-cloud-pricing -77 B (-0.0%) -62 B (-0.0%)
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.
Legend
What is parsed and gzip size?
Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.
Generated by performance advisor bot at iscalypsofastyet.com.