wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

[Do not merge] approach on reusing CTAButton

Open candy02058912 opened this issue 3 years ago • 2 comments

Task-related: https://github.com/Automattic/wp-calypso/issues/68089

Proposed Changes

Testing Instructions

Pre-merge Checklist

  • [ ] Have you written new tests for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [ ] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?

Related to #

candy02058912 avatar Sep 22 '22 11:09 candy02058912

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~692 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                              +3532 B  (+0.1%)     +665 B  (+0.1%)
jetpack-cloud-plugin-management      +1537 B  (+0.2%)     +285 B  (+0.1%)
plans                                  +63 B  (+0.0%)      +27 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~31 bytes added 📈 [gzipped])

name                           parsed_size           gzip_size
async-load-signup-steps-plans        +63 B  (+0.0%)      +31 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Sep 22 '22 12:09 matticbot

This also fixes #68120

lupus2k avatar Sep 22 '22 23:09 lupus2k