wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Fix Stylelint error for rule: `selector-type-no-unknown`

Open brookewp opened this issue 3 years ago • 3 comments

Related to: #67467

Proposed Changes

Original PR for this was closed due to issues with the branch #67996

There was only one error for selector-type-no-unknown when running yarn lint:css. Since the selector was broken and we have blocks now, the CSS isn't being used. So to fix this error, I'm proposing to remove the CSS which will keep trunk looking the same while removing the stylelint error.

Testing Instructions

  1. TeamCity
  2. Add Twitter link to post and see it is still left-aligned in Reader

brookewp avatar Sep 21 '22 23:09 brookewp

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Sep 21 '22 23:09 matticbot

There are 2 more places with the same error:

client/components/advanced-credentials/style.scss
 68:8  ✖  Unexpected unknown type selector "first-child"  selector-type-no-unknown

client/landing/domains/content-card/style.scss
 44:2  ✖  Unexpected unknown type selector                 selector-type-no-unknown
          "content-card__alternate-action-button"

manzoorwanijk avatar Sep 22 '22 10:09 manzoorwanijk

Thanks for sharing, @manzoorwanijk! I'm not sure why they aren't showing up when I run yarn lint:css but I'll fix those two as well.

brookewp avatar Sep 27 '22 00:09 brookewp