wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Plugin Management: replace old tables in plugin details with the new design in Calypso Blue

Open yashwin opened this issue 3 years ago • 2 comments

Proposed Changes

This PR replaces the old table design used in plugin details with the new design in Calypso Blue and also fixes an issue where the notification is shown below the modal, which was not visible clearly.

Testing Instructions

Instructions

  1. Run git checkout update/plugin-details-table-on-calypso-blue and yarn start.
  2. Visit http://calypso.localhost:3000/plugins/manage and click on any plugin to visit the details page.
  3. Click on Manage Sites on the right column
Screenshot 2022-09-21 at 5 05 52 PM
  1. Verify that the old plugin table is replaced with the new table design, and you can view the tooltip, open the actions menu, and notifications on the top of the modal.
Before After
Screenshot 2022-09-21 at 5 35 22 PM Screenshot 2022-09-21 at 4 12 40 PM

Pre-merge Checklist

Complete applicable items on this checklist before merging into the trunk. Inapplicable items can be left unchecked.

The PR author and reviewer are responsible for completing the checklist.

Related to 1202518759611394-as-1202993209552908

yashwin avatar Sep 21 '22 11:09 yashwin

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~175 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                               +169 B  (+0.0%)     +175 B  (+0.1%)
jetpack-cloud-plugin-management       +169 B  (+0.0%)     +175 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Sep 21 '22 11:09 matticbot

The 'Manage subscription' button is missing. Also, the 'Purchase + Activate' button should not break into two lines.

Thanks for testing this. I have fixed this now.

Screenshot 2022-09-23 at 10 31 54 AM

yashwin avatar Sep 23 '22 05:09 yashwin