wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Add loading step on LIB flow

Open renancarvalho opened this issue 2 years ago • 5 comments

Proposed Changes

After the link-in-bio setup step, when submitting the form, the user should see the loading step that is basically a loader while the data is being handled/submitted.

It should look like the designs besides the background that is not the one on the design, it will be changed later.

image

Testing Instructions

  • Run yarn start from the calypso root folder
  • Navigate to http://calypso.localhost:3000/setup/linkInBioSetup?flow=link-in-bio&siteSlug=YOUR-SITE.wordpress.com
  • Fill the form and click on continue
  • You should see the loader as the described above. ( It will be fast given we have little data and the whole action happens quite fast )
  • After that you should be redirect to temporary page, http://calypso.localhost:3000/page/YOUR-SITE.wordpress.com/home. ( will be changed later )

Related to #66396 Fixes #66396

renancarvalho avatar Aug 09 '22 10:08 renancarvalho

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~151 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +408 B  (+0.0%)     +151 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Aug 09 '22 10:08 matticbot

Hi @escapemanuele, Thank you for checking it, indeed it is a bit misaligned, pushing the fix soon. I also noticed that the print you provided is not up to date with the correct text and progress bar.

it should look like these image

image

Thank you!

renancarvalho avatar Aug 09 '22 15:08 renancarvalho

Screenshot 2022-08-10 at 12 27 03 1

Are we missing the image background in the loading step?

heavyweight avatar Aug 10 '22 10:08 heavyweight

@heavyweight I appreciate your review. Yes, we will use this background color for now as @alshakero suggested.

renancarvalho avatar Aug 10 '22 10:08 renancarvalho

Not relevant anymore

renancarvalho avatar Aug 12 '22 11:08 renancarvalho