wp-calypso icon indicating copy to clipboard operation
wp-calypso copied to clipboard

Update wording for domain subscription description in purchases page

Open daledupreez opened this issue 3 years ago • 4 comments

Proposed Changes

  • This PR implements the wording changes from https://github.com/Automattic/wp-calypso/issues/63891, specifically in this comment

Testing Instructions

  • For a site where you have a domain registration or domain mapping, navigate to Upgrades -> Purchases
  • Click on a row for a domain registration or domain mapping
  • Verify that the description for the subscription uses the following language:

When used with a paid plan, your custom domain can replace your site's free address, [wordpress.com_url], with [custom_domain], making it easier to remember and easier to share.

Screenshot
Screenshot 2022-08-04 at 14 53 00

Pre-merge Checklist

  • [ ] Have you written new tests for your changes?
  • [ ] Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • [x] Have you checked for TypeScript, React or other console errors?
  • [ ] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • [ ] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • I will add the string freeze label once we confirm the wording

Related to #63891

daledupreez avatar Aug 04 '22 13:08 daledupreez

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~64 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases       +155 B  (+0.0%)      +64 B  (+0.0%)
purchases            +155 B  (+0.0%)      +64 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot avatar Aug 04 '22 13:08 matticbot

The copy change looks good to me!

wensco avatar Aug 04 '22 13:08 wensco

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7464772

Thank you @daledupreez for including a screenshot in the description! This is really helpful for our translators.

a8ci18n avatar Aug 05 '22 10:08 a8ci18n

Translation for this Pull Request has now been finished.

a8ci18n avatar Aug 12 '22 16:08 a8ci18n

I have deployed this already, @daledupreez.

mpkelly avatar Aug 14 '22 06:08 mpkelly