wordpress-activitypub icon indicating copy to clipboard operation
wordpress-activitypub copied to clipboard

Migration: Re-use async batch infrastructure

Open obenland opened this issue 10 months ago • 4 comments

One thing I noticed while testing these changes is that we'll end up with a lot of activitypub_async_batch events that kind of obscure what they do until you look at the args for the individual jobs. Not sure how we feel about that. Maybe we should just keep it to batches and not move the async_migration job?

Proposed changes:

  • Updates migration jobs to re-using the Scheduler::async_batch infrastructure
  • Update tests to account for the above changes.

Other information:

  • [x] Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

obenland avatar Feb 19 '25 17:02 obenland

@obenland what about this PR?

pfefferle avatar Apr 22 '25 15:04 pfefferle

Depends on #1521.

obenland avatar Apr 22 '25 15:04 obenland

@pfefferle This should be ready for review

obenland avatar May 28 '25 18:05 obenland

After team call: Let's make it possible to fill the Scheduler from class-migrations.php.

Meaning, how can we expand the batch callback allow list from the migration class. Also move action hooks back into the migration class. Could also be done in Migration::async_migration.

obenland avatar Jun 02 '25 15:06 obenland