vip-scanner

vip-scanner copied to clipboard

It doesn't work on WordPress.com.

joshbetz

phpcs and WordPress Coding Standards are installed and running in `/MAMP/bin/php/phpx.x.x/bin/` but VIP Scanner doesn't detect phpcs. ``` text PHP CodeSniffer not available PHP CodeSniffer (phpcs) is not available on...

ivorpad

We can find all functions that can return a `WP_Error`, then check that all calls to the function properly test `is_wp_error()` on the return value before doing anything else.

nickdaugherty

Flag plugins that are enabled via UI, but not in code on VIP sites

1

Plugins should almost always be enabled in code, not the UI. If a VIP client is developing against VIP plugins that have been enabled via UI, they are not guaranteed...

nickdaugherty

Standard way of indicating skipped directories

8

VIP Scanner gets pretty useless when it scans `/node_modules`, etc. There should be a standard way of marking files / directories to skip in the scan.

danielbachhuber

scan-theme CLI command hides errors without lines

1

If you have errors without `lines`, these will be hidden from the `scan-theme` output, which is incredibly confusing. Adding `--format=json` will show this, but JSON isn't the best format for...

rmccue

nickdaugherty

BOMs can come back to haunt you in tricky ways...for example, a BOM in a PHP file will get output with an HTTP response...and that can end up breaking things...

nickdaugherty

The rules defined in `vary_cache_on_function()` here: https://github.com/Automattic/batcache/blob/master/advanced-cache.php#L32-L36 A variant that includes one of `include|require|echo|print|dump|export|open|sock|unlink|`|eval`or does *not* include a reference to a superglobal (regex check for`$_`) will fail and we should...

nickdaugherty

Toolbar issues indicator isn't accurate or consistent

4

Steps to reproduce: 1. Install a theme, we used the Headlines theme linked at the bottom of https://sp.automattic.com/themes/thread.php?t=2989 in our example 2. Install the VIP Scanner version 0.7 3. Go...

designsimply