vip-go-mu-plugins icon indicating copy to clipboard operation
vip-go-mu-plugins copied to clipboard

Add eslint-config-preact and fix found issues

Open sjinks opened this issue 1 year ago • 2 comments

Description

This PR adds eslint-config-preact and fixes the issues found by the linter (mainly react-hooks/exhaustive-deps). Also, this PR removes all uses of dangerouslySetInnerHTML.

Changelog Description

Plugin Updated: Search Dev Tools

Minor bug fixes.

Checklist

Please make sure the items below have been covered before requesting a review:

  • [x] This change works and has been tested locally (or has an appropriate fallback).
  • [ ] This change works and has been tested on a Go sandbox.
  • [ ] This change has relevant unit tests (if applicable).
  • [ ] This change has relevant documentation additions / updates (if applicable).
  • [x] I've created a changelog description that aligns with the provided examples.

Steps to Test

E2E tests should pass.

sjinks avatar Aug 16 '22 03:08 sjinks

Codecov Report

Merging #3538 (37a0792) into develop (d7b4c55) will decrease coverage by 0.02%. The diff coverage is 30.00%.

@@              Coverage Diff              @@
##             develop    #3538      +/-   ##
=============================================
- Coverage      34.01%   33.98%   -0.03%     
- Complexity      3549     3551       +2     
=============================================
  Files            217      217              
  Lines          13887    13896       +9     
=============================================
  Hits            4723     4723              
- Misses          9164     9173       +9     
Impacted Files Coverage Δ
search/includes/classes/class-healthjob.php 30.23% <0.00%> (-4.91%) :arrow_down:
search/includes/classes/class-search.php 84.85% <75.00%> (-0.07%) :arrow_down:
lib/statsd/class-statsd.php 27.45% <0.00%> (-3.93%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 16 '22 03:08 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] avatar Aug 16 '22 14:08 sonarcloud[bot]