vip-go-mu-plugins icon indicating copy to clipboard operation
vip-go-mu-plugins copied to clipboard

2fa: Change placeholder phone number

Open trepmal opened this issue 4 years ago • 1 comments

https://github.com/Automattic/vip-go-mu-plugins/blob/bb29dd028c771aec996b61a38aa7cc259f31e0a7/wpcom-vip-two-factor/sms-provider.php#L196

I might be the only person, but I was unfamiliar with this phone number easter egg. Additionally, the 415 area code made me think this might be a genuine a8c number.

I think it would be good to switch this to a more readily recognizable fake number (555...., 123..., or even ###...) so that no one will, like me, glance at this and think their 2fa codes might be going to an unknown party.

trepmal avatar Sep 16 '21 21:09 trepmal

There are all sorts of issues here, such as a requirement to include country code numbers, and not using a placeholder that is US-specific.

https://uxmovement.com/forms/bad-practices-on-phone-number-form-fields/ has a good write-up, and https://uxplanet.org/phone-number-field-design-best-practices-23957cbd86d5 suggests include a country-code dropdown.

Maybe consider using https://github.com/jackocnr/intl-tel-input

GaryJones avatar Sep 17 '21 11:09 GaryJones

This issue has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep issues manageable and actionable and is not a comment on the quality of this issue nor on the work done so far. Closed issues are still valuable to the project and are available to be searched.

github-actions[bot] avatar Sep 17 '22 00:09 github-actions[bot]