vip-block-data-api icon indicating copy to clipboard operation
vip-block-data-api copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

Add min php and wp notice

Open ingeniumed opened this issue 1 year ago • 1 comments

Description

I realized we don't have a PHP and WP version check and the one we have been relying won't really be enforced for the way we expect this plugin to be deployed. So I have added in a manual check, akin to what we have in the workflow plugin.

This is already what the plugin supports so it's just matching that.

Steps to Test

Either load a WP version prior to 6.0 with PHP version lower than 8.0, or change those numbers to something arbitrary and see it fail.

ingeniumed avatar Sep 12 '24 04:09 ingeniumed

Changes look good to me, but I'm not sure that we need to bump the version and do a release for this PR alone. What about leaving it at 1.4.1, and then this will get merged when we do a next release?

Agreed on that, works for me tbh

ingeniumed avatar Sep 17 '24 22:09 ingeniumed