themes icon indicating copy to clipboard operation
themes copied to clipboard

Blockbase: allow opting out of specific style variation

Open pkevan opened this issue 10 months ago • 2 comments

Quick summary

As reported in: https://github.com/Automattic/themes/issues/8636#issuecomment-2620887613, excludedParentStyleVariations does not work as expected, and style variation remain present despite being set in the child theme.

Steps to reproduce

Choose any child theme of Blockbase, i.e Marl where the style variation Ruby Wine should be removed.

Observe that the within Editor -> Style -> Colors -> Edit Palette that the Ruby Wine style variation still appears.

Reproducible via Simple sites.

Site owner impact

More than 60% of the total website/platform users

Severity

Major

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

Platform (Simple and/or Atomic)

Simple

pkevan avatar Jan 31 '25 16:01 pkevan

📌 ACTIONS

  • Set to Triaged
  • Set to Priority: High
  • Assigned Team Neso

📌 Message to Author @pkevan I've assigned this to Team Neso, as it seems you've already been working on this, as per the closed issue where it was discussed before this one was opened.

As you've identified and confirmed the issue, it did not need excessive testing, though I was able to confirm same, in terms of the 'Ruby WIne' color palette option appearing for child theme, Blockbase, Marl.

janmckell avatar Feb 03 '25 20:02 janmckell

The place it was discussed was for a slightly different issue and functionality, so this was created for this instance.

A PR is already created to resolved this (https://github.com/Automattic/themes/pull/8673)

pkevan avatar Feb 04 '25 08:02 pkevan