themes icon indicating copy to clipboard operation
themes copied to clipboard

Assembler: Add two new typography styles

Open alaczek opened this issue 1 year ago • 5 comments

Proposing two new font combos:

  • Playfair Display + Figtree
  • Rubik + Tilda Sans

I came up with these two font combos while working on ready made templates.

The Playfair Display + Figtree is meant to complement our offering of elegant font pairings. The Rubik + Tilda Sans is a combo I grabbed from the Cortado theme (swapping Plus Jakarta Sans for Tilda).

Playfair Display + Figtree Rubik + Tilda Sans
image image

cc @richtabor

alaczek avatar Jul 30 '24 04:07 alaczek

Preview changes

I've detected changes to the following themes in this PR: Assembler.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

github-actions[bot] avatar Jul 30 '24 04:07 github-actions[bot]

I'm not getting the Playfair Display to work here?

CleanShot 2024-08-02 at 16 41 24

richtabor avatar Aug 02 '24 20:08 richtabor

Looks like fonts aren't loading properly for either.

I see, we need to register them in theme.json, like the other fonts.

CleanShot 2024-08-02 at 16 42 10

richtabor avatar Aug 02 '24 20:08 richtabor

@beafialho what do you think of these font combinations?

richtabor avatar Aug 02 '24 20:08 richtabor

I see, we need to register them in theme.json, like the other fonts.

Yep, I totally forgot to push the updated theme.json.

alaczek avatar Aug 06 '24 00:08 alaczek

I'm going to close this based on the typography improvements we did in https://github.com/Automattic/themes/pull/8421. Thanks!

richtabor avatar Dec 05 '24 16:12 richtabor