themes icon indicating copy to clipboard operation
themes copied to clipboard

OutNow: Static link in the front page template

Open alaczek opened this issue 1 year ago • 1 comments

I noticed this line the front page template in OutNow

<h1 class="wp-block-heading alignwide no-underline"><?php echo __('<a href="/blog/" data-type="page" data-id="2">Read the msgrs</a>', 'outnow');?></h1>

From: https://github.com/Automattic/themes/blob/5e0efe7ba49de1a1c738ec5d260df4d4d67ddc39/outnow/patterns/front-page.php#L44C1-L44C152

There are a couple issues here:

  • The link text is not translatable.
  • It's also unclear to me what msgrs means, so I imagine translating it would be hard.
  • The link /blog/ is static and won't work unless the customer has a page called Blog on their site (assuming that page would have query loop in it and display blog posts)

To improve usability of this theme I would recommend displaying four posts in a grid, without navigation. While not ideal I think it would be less confusing than a broken link. I tried adding nav inside the grid or below, but it won't work since the pagination block needs to be inside the Query loop.

cc @henriqueiamarino

alaczek avatar Jul 18 '24 01:07 alaczek

Thanks, @alaczek. This is fixed by #7956. All four niches now have query loops displaying a single post, all ruled by the offset setting.

henriqueiamarino avatar Jul 18 '24 08:07 henriqueiamarino