themes
themes copied to clipboard
Brightblog: add theme
Brightblog is a blog theme with large typography and vibrant color palettes. With its clean and modern design, it offers a unique and engaging way to showcase your blog content.
Preview changes
I've detected changes to the following themes in this PR: Brightblog.
You can preview these changes by following the links below:
I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.
General visual observations
Demo site looks nice, very colorful, bold.
There's something about the logo here that isn't quite legible, and the stripes look too similar to the burger menu:
Not a blocker of course, as it's just demo content, just a thought.
One challenge to consider for future themes is to make it behave slightly better when no featured images are set:
There's a fair bit of whitespace to the left of the post, and the heading sticks pretty close to the header in this screenshots. Small fixes could be to simply add some top/bottom padding to the post itself, so that the whitespace feels more intentional and clearly indicated as intentional whitespace.
Should the color of the overlay be set to better match the colors of the site/style variation?
A more general question, not a blocker. You've correctly included and use the site logo as the "Home" link. But when no image is set, in this particular design, there's no home link at all:
It's mostly an intereresting question to ponder for us on the block editor site, perhaps. It feels reasonable for a theme to more or less require that a site icon be set, in order to fully work well.
Should these be linked?
Just to #, but just so the visual style (underlined, probably), is more visible.
Mobile looks great.
Other
Templates look good.
Style variations are fun. Slightly crazy, but that matches the colorful nature of the theme.
Readme looks good.
Summary
This is a fun one. A few tiny things to look at fixing, but we can get this one going, I think.
Thanks, @jasmussen. I reviewed it following your feedback.
Changes look good, almost! There's a glitch here:
Pretty sure it's from changes here:
So instead of:
<?php esc_html_e('<a href="#">Instagram</a>', 'brightblog');?>
You can do:
<a href="#"><?php esc_html_e('Instagram', 'brightblog');?></a>
CBT has been showing this error for a couple of weeks. All links break like that. Pixel fellows are already informed. I hope they fix it soon.
@madhusudhand is this a CBT issue, do you know?
Thanks for following this up, @jasmussen. The manual fix worked fine on the links.
@madhusudhand is this a CBT issue, do you know?
Yes, it is related to https://github.com/WordPress/create-block-theme/issues/573
Thanks Madhu!
I guess this PR is good to go then, given you made manual fixes?
Okay, @jasmussen; thank you once more.