themes icon indicating copy to clipboard operation
themes copied to clipboard

Assembler: Use variation partials and move styles.blocks.variations to styles.variations

Open richtabor opened this issue 1 year ago • 6 comments

Follow up to https://github.com/WordPress/gutenberg/pull/62712, which adjusts where block style variations are defined with in theme style variations, as well as better leveraging style variation partials.

To test, load up https://github.com/WordPress/gutenberg/pull/62712, then change to alternate color palettes. It should work exactly as previously.

richtabor avatar Jun 21 '24 20:06 richtabor

Relies on https://github.com/WordPress/gutenberg/pull/62712 merged, into Gutenberg and perhaps for WordPress 6.6.

richtabor avatar Jun 21 '24 20:06 richtabor

Preview changes

I've detected changes to the following themes in this PR: Assembler.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

github-actions[bot] avatar Jun 21 '24 20:06 github-actions[bot]

Tested well for me on Gutenberg trunk (18.7RC) and WP 6.5.5

glendaviesnz avatar Jul 01 '24 01:07 glendaviesnz

Went ahead and tweaked the form input styles to work better across all block style variations as well.

richtabor avatar Jul 01 '24 20:07 richtabor

@alaczek @miksansegundo Do you mind giving this another good look over? Much appreciated! 🙇

richtabor avatar Jul 03 '24 23:07 richtabor

I'm still reviewing this.

So far, I have found some issues with some variations:

  • A low contrast between the background and text colors on the footer.
  • Some colors in the variation card aren't applied in the preview.

miksansegundo avatar Jul 04 '24 13:07 miksansegundo

A low contrast between the background and text colors on the footer.

This issue is not in the variations but in the preview of the Dotcom theme details page. I'm debugging it.

Some colors in the variation card aren't applied in the preview.

This issue affects the editor and assembler and is in the JSON files of Auburn, Meadow, Fluorescent, Citron, Sunset, Blush, and Tangerine. Can we update the default colors for these?

I would expect those variations to use some of their most representative colors in their default section style variation, but they don't, and when choosing them in the editor or Assembler flow, they look black and white.

Screenshot 2567-07-05 at 14 04 36

Here are the previews for Auburn, as an example:

Screenshot 2567-07-05 at 14 07 01 Screenshot 2567-07-05 at 14 06 43 Screenshot 2567-07-05 at 14 06 31

miksansegundo avatar Jul 05 '24 07:07 miksansegundo

I would expect those variations to use some of their most representative colors in their default section style variation, but they don't, and when choosing them in the editor or Assembler flow, they look black and white.

This issue affects the editor and assembler and is in the JSON files of Auburn, Meadow, Fluorescent, Citron, Sunset, Blush, and Tangerine. Can we update the default colors for these?

I would expect those variations to use some of their most representative colors in their default section style variation, but they don't, and when choosing them in the editor or Assembler flow, they look black and white.

Here are the proper colors, as seen in the Assembler theme when viewing it locally. They are representative of their colors. Is the demo site using G 18.7+?

Meadow Citron
CleanShot 2024-07-05 at 11 30 33 CleanShot 2024-07-05 at 11 32 38

richtabor avatar Jul 05 '24 15:07 richtabor

We should also update the demo site for Assembler to showcase more content (perhaps the second pattern could have a section style, but not the third—don't want to overdo it.

CleanShot 2024-07-05 at 11 39 26

richtabor avatar Jul 05 '24 15:07 richtabor