themes icon indicating copy to clipboard operation
themes copied to clipboard
verified publisher icon Automattic

Atrium: add theme

Open henriqueiamarino opened this issue 1 year ago • 1 comments

Atrium is a blog theme that presents posts in different Query Loops using tags—the perfect pick for museums or galleries. Demo site

screenshot

henriqueiamarino avatar Jun 21 '24 09:06 henriqueiamarino

Preview changes

I've detected changes to the following themes in this PR: Russell, Professional Business, Sunderland, Maywood, Alves, Farrow, Loïc, Otis, Meraki, Photos, Elegant Business, Shawburn, Rockfield, Coutoire, Brompton, Stow, Stratford, Vitrum, Artly, Hall, Exford, Morden, Cookbook, Attar, Seedlet, Mayland, Modern Business, Rivington, Sophisticated Business, Dorna, Redhill, Balasana, Appleton, Calm Business, Hever, Heiwa, Barnsbury, Dalston, Marl, Varia, Erma, Leven, Friendly Business.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

⚠️ Note: Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

github-actions[bot] avatar Jun 21 '24 09:06 github-actions[bot]

General visual observations

Nice museum piece! I like how things line up vertically and horizontally in a 4 column grid here:

Screenshot 2024-07-05 at 14 03 01

"View all" looks a teeny bit too thin in font weight: Screenshot 2024-07-05 at 14 03 43

This font weight is better:

Screenshot 2024-07-05 at 14 06 23

Things don't line up on the subpage:

Screenshot 2024-07-05 at 14 06 45

Maybe it's that padding change we discovered in another PR?

It's unfortunate that the default "My WordPress Website" title text makes the header look like this:

Screenshot 2024-07-05 at 14 04 02

But this is not something you can do much about, except to provide good demo content, which you have.

For anyone else reviewing, there's a bit much whitespace here, but it's intentional:

Screenshot 2024-07-05 at 14 04 53

The top half of the page is set in a 100vh container, so if you make the browser less tall, so will the whitespace be less tall.

Mobile looks great. Nicely done.

Template review

Templates look good.

Style variations

This is one of the older themes, so it's mostly different in color. As I've noted in other themes, it'd be nice to go a bit broader here, with typography, possibly radius, duotone. For a museum theme like this, I would love to see a delightful serif version, but also very stark light mode grayscale themes, and a dark mode black theme, to be "neutral" and let the content stand out. You might even apply duotones to the imagery to have them match.

File and readme reviews

Good job including links to the PD images. And Overused Grotesk is very lovely.

Summary

Nice one!

There were some small padding/lining up, a font weight thing, and optionally some more diverse style variations. I'll defer to you on where to land, but codewise, this one is good to ship!

jasmussen avatar Jul 05 '24 12:07 jasmussen

As always, thanks for the feedback, @jasmussen. You have good points here; I'll consider them before proceeding.

henriqueiamarino avatar Jul 05 '24 13:07 henriqueiamarino

I am closing this PR as I commit unwanted changes related to #7925. I'll create a new PR before merging until I feel safe fixing this sort of issue or proceeding without caring about it.

henriqueiamarino avatar Jul 05 '24 15:07 henriqueiamarino