themes icon indicating copy to clipboard operation
themes copied to clipboard
verified publisher icon Automattic

Craftfully: Fix for missing "contrast" preset color

Open miksansegundo opened this issue 1 year ago • 4 comments

Changes proposed in this Pull Request:

  • Rename the color preset named contrast as foreground because contrast doesn't exist.

@alaczek I wasn't sure if you wanted to create a contrast preset or use foreground instead.

Related issue(s):

Screenshot 2567-03-15 at 16 02 38

miksansegundo avatar Mar 15 '24 12:03 miksansegundo

Not sure what you mean by "because contrast doesn't exist."?

I think with this theme I was following the naming convention from TT4, and I did want to use contrast.

alaczek avatar Mar 19 '24 02:03 alaczek

I am confused now. I think is the other way around as how I describe it in this PR.

The markup uses "foreground" but that color is not defined in the theme.json.

miksansegundo avatar Mar 19 '24 09:03 miksansegundo

See "foreground" being used here

miksansegundo avatar Mar 19 '24 09:03 miksansegundo

Oh yeah, in that case it should be switched to contrast.

alaczek avatar Mar 20 '24 05:03 alaczek

Okay, closing this in favor of https://github.com/Automattic/themes/pull/7787 Could you review and merge that?

miksansegundo avatar Apr 30 '24 02:04 miksansegundo