themes icon indicating copy to clipboard operation
themes copied to clipboard

Fewer: Overlapping feature image with text in category view when image is small

Open dereksmart opened this issue 2 years ago • 5 comments

Minor styling issue in the Fewer theme category view when using small featured image.

Steps to replicate

  • Create a few posts all having the the same category.
  • Select feature images for all the posts.
  • Use a small featured image in one of the posts (~300px height)
  • View the category page on a wide screen. [SITE].com/category/your-category

Result

The image overflows over the taxonomy and title:

image

Expected

For the image container to have a minimum height, accommodating the smaller image.

  • Follow-up ticket: 7156745-zd-a8c

dereksmart avatar Oct 24 '23 16:10 dereksmart

Support References

This comment is automatically generated. Please do not edit it.

  • [ ] 7156745-zen

github-actions[bot] avatar Oct 24 '23 16:10 github-actions[bot]

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO Replicated as described:

Markup on 2023-10-26 at 13:48:32

Tested with this 320 × 183 file: woo_bubble_sticker Small

Switching to TT3 shows how TT3 handles the smaller featured image by containing it in the post template: https://github.com/Automattic/themes/assets/27249804/5c9558d9-9a5b-48a4-91ec-c6cdcf60044e

📌 ACTIONS

  • Triaged

cuemarie avatar Oct 26 '23 20:10 cuemarie

I believe this needs to be fixed in the Gutenberg repo. Is that right @annezazu?

davemart-in avatar Oct 18 '24 17:10 davemart-in

Noting that I replicated this (we need to confirm that first) on https://testttting179142315.wordpress.com/. Specifically, I switched to the Fewer theme, added a post using the Woo image above (small!), and added a post with a larger featured image. It all shows up correctly on the homepage:

Image

On the category page, it overlaps https://testttting179142315.wordpress.com/category/uncategorized/

Image

To fix this, if I add aspect ratio to the featured image, it corrects itself:

Image

As a result, I'd recommend we add aspect ratio to the theme for featured images for these templates in the meantime. I also think it makes sense to open a Core issue but am curious to hear from @mikachan around what the report might be exactly. I'd rather open something more specific and couldn't find anything exactly similar, this was the closest: https://github.com/WordPress/gutenberg/issues/52238

annezazu avatar Oct 18 '24 20:10 annezazu

Hmm, I'm not sure if this is a Core issue, although I'm struggling to think of a case where this behaviour would be intentional!

Looking at the templates in Fewer, it looks like the post template markup is slightly different between index, home, archive, and search, so I'm wondering if a better fix for this would be to use the block markup used on the home template for every template, as that seems to work best for the featured image display.

mikachan avatar Oct 23 '24 16:10 mikachan