themes icon indicating copy to clipboard operation
themes copied to clipboard

Tsubaki: changing 'all' Heading font in Styles does nothing

Open tvolpert opened this issue 2 years ago • 11 comments

Edit: Please see https://github.com/Automattic/themes/issues/7152 for larger context and workarounds (also noted below)

Quick summary

If you use the Styles menu within the Site Editor, and try to change the font family for all headings at the same time, nothing happens.

Steps to reproduce

  1. open a site using the Tsubaki theme
  2. add some heading blocks that you can see in the Site Editor
  3. in the Site Editor, open Styles > Typography > headings
  4. leave the "All" option selected (rather than choosing H1 or H2 etc individually) and change the font to any of the available options: cdAJ5d.png

note: changing the font for H1 or H2 etc individually works, but if you try to select default from the dropdown (which I assume would make them use the font set under all, it immediately reverts to system font instead

What you expected to happen

The fonts for all Heading elements should be changed, unless they're overridden at the individual level

What actually happened

no font change occurs

Context

reported in 39140532 and followed up in 5824343-zen

Platform (Simple, Atomic, or both?)

Atomic

Theme-specific issue?

Tsubaki

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

Users can still set the font family for Headings by setting them at each level individually. Setting h1, h2, h3, h4, h5 and h6 each to the same font has the same effect as changing all fonts at once, but is more labor-intensive

tvolpert avatar Dec 29 '22 20:12 tvolpert

Support References

This comment is automatically generated. Please do not edit it.

  • [ ] 5824343-zen
  • [ ] 6451860-zen

github-actions[bot] avatar Dec 29 '22 20:12 github-actions[bot]

Able to reproduce. Leaving Low priority due to low impact.

zachspears avatar Dec 30 '22 01:12 zachspears

I think this would be better in https://github.com/Automattic/themes/issues

simison avatar Dec 30 '22 11:12 simison

Identical to https://github.com/Automattic/themes/issues/6793

simison avatar Dec 30 '22 14:12 simison

Probably a duplicate of https://github.com/Automattic/wp-calypso/issues/71641

dsas avatar Jan 05 '23 18:01 dsas

  • [ ] #6386644

mriyazuddin avatar Jun 09 '23 05:06 mriyazuddin

This issue also affects Russel and Byrne, and probably affects all Blockbase themes. I'm increasing the priority to High for that reason.

masperber avatar Jun 21 '23 17:06 masperber

Customer reported in 6451860-zen.

I am providing CSS as a workaround.

masperber avatar Jun 21 '23 17:06 masperber

📌 ACTIONS Put together a larger report here:

  • https://github.com/Automattic/themes/issues/7152

📌 WORKAROUND

In the meantime, a default Heading font family can be set under Styles > Blocks > Heading > Typography > FONT instead.

cuemarie avatar Jun 21 '23 22:06 cuemarie

I can reproduce this problem on a simple site with a Premium plan. ✅

I CANNOT reproduce it on a local site running the Tsubaki theme. ❌

michalczaplinski avatar Jan 21 '25 15:01 michalczaplinski

I was eventually able to reproduce the issue locally and created a PR that should fix it: 154555-ghe-Automattic/wpcom-premium-themes

michalczaplinski avatar Jan 22 '25 19:01 michalczaplinski