themes icon indicating copy to clipboard operation
themes copied to clipboard

Cubic: Slideshow blocks shows images zoomed in

Open ariel-maidana opened this issue 2 years ago • 5 comments

Quick summary

Regardless of the Alignment settings, the Slideshow block is showing images zoomed in on simple sites with the Cubic theme. Related issue: https://github.com/Automattic/jetpack/issues/12178

p1658354400641829-slack-CB0B2G43X

Steps to reproduce

  1. Activate the Cubic theme in a simple site.
  2. Create a post.
  3. Create a slideshow.
  4. Add some images with different aspect ratios.
  5. Publish or preview the post.

What you expected to happen

I would expect to see the full images.

What actually happened

Images appeared zoomed in and cropped.

Context

5548552-zd-woothemes

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

Reproduced in Cubic.

Browser, operating system and other notes

No response

Reproducibility

Once

Severity

No response

Available workarounds?

No response

Workaround details

No response

ariel-maidana avatar Sep 13 '22 19:09 ariel-maidana

Support References

This comment is automatically generated. Please do not edit it.

  • [ ] 5548552-zen
  • [ ] 5645307-zen
  • [ ] 7418975-zen

github-actions[bot] avatar Sep 13 '22 19:09 github-actions[bot]

📌 SCRUBBING : RESULT

  • Tested on Simple - Replicated
  • Tested on Self-hosted - Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Was able to replicate this on a simple and self-hosted test site.
  • In my tests this was only happening on the Cubic theme, not when I tested on another theme like Pendant.
  • It seems like it is not affecting all images, but some images are zoomed and some of the next image is visible.
  • Screenshot: Slideshow issue

📌 ACTIONS

  • Marked as Triaged for Quality Squad review

jamiepalatnik avatar Sep 15 '22 15:09 jamiepalatnik

Created a patch D88642-code

danielbachhuber avatar Sep 27 '22 18:09 danielbachhuber

Reviewed, changes suggested in diff patch.

jeffikus avatar Sep 27 '22 18:09 jeffikus

@jeffikus Unassigning this from myself. Feel free to ping me if you need any further testing, etc.

danielbachhuber avatar Oct 10 '22 11:10 danielbachhuber

User is asking for an update. It is not clear to me if this is being solved. Could you share some more details?

daria2303 avatar Oct 19 '22 17:10 daria2303

@daria2303 I'm not sure where this lives in the Theme team's set of priorities.

You can share this CSS with the user so they can fix it for their site.

@media screen and (min-width: 768px) {
	.wp-block-jetpack-slideshow .image-big {
		margin-left: 0px;
		margin-bottom: 0px;
	}
}

danielbachhuber avatar Oct 20 '22 19:10 danielbachhuber

@danielbachhuber This does not work for the vertical images in the gallery block as seen in this case: 5645307-zd-woothemes

Could you please check?

devNigel avatar Oct 24 '22 07:10 devNigel

@devNigel Sorry for the delay! I was tied up in another project.

Here's some CSS they can use to have the vertical images display fully:

.entry-content .wp-block-jetpack-slideshow .wp-block-jetpack-slideshow_slide figure {
  align-items: initial;
}

.entry-content .wp-block-jetpack-slideshow .wp-block-jetpack-slideshow_slide figure img {
  margin-left: auto;
  margin-right: auto;
}
image

danielbachhuber avatar Oct 28 '22 14:10 danielbachhuber

One more case with Alves theme in zd-5920463

I was able to reproduce it: https://d.pr/i/xT5oAN

Babylon1999 avatar Feb 11 '23 12:02 Babylon1999

43339352-hc Hever theme. CSSs suggested did not work.

csabarakasz avatar May 10 '23 13:05 csabarakasz

Another report here: 7418975-zen

AnjanaV93 avatar Dec 08 '23 06:12 AnjanaV93