themes Loudness: Styles: Comments

There are no designs for comments.

The "default" (Block Canvas) comments template was cleaned up in #6563 for this.

This is what it looks like unmodified. Are there any design changes we should make?

Sep 13 '22 14:09 pbking

Hey @pbking as I'm not sure about the spacing units that we are using I am fixing it as done in Pixl. It worked just fine! Let's set these spacing as related... layout, type and colors are good enough to go!

response-feedback_decibel

response-feedback_figma

Sep 16 '22 08:09 henriqueiamarino

I'm not sure how much control of some of the above spacing we (easily) have. Gonna leave it as-is with this work as TBD and we'll see if we can tackle some of the spacing concerns you have down the road a bit.

Sep 19 '22 17:09 pbking

I looked into the differences between Pixl and Loudness (and also Block Canvas).

While all of the templating and relevant style opinion seems to be the same between the themes the differences illustrated above still seem to persist and I can't quite figure out why. There are different margins throughout and ¯_(ツ)_/¯

More research is needed. However I hoping that perhaps the existing layout is "good enough" to ship that that this issue doesn't hold up the release of Loudness if we can't get to the bottom of those differences.

Sep 29 '22 12:09 pbking

Loudness is going to use the default spacing in the comments block so I'm going to close this issue.

Oct 28 '22 14:10 pbking