Automattic
Rockfield/fix/button border
Changes proposed in this Pull Request:
Added CSS to fix button outline on buttons that are selected with filled background. CSS is from open issue. Changed existing border style to none and added CSS for contact form. Also changed border style to none in the editor styles to match front-end.
Related issue(s):
https://github.com/Automattic/themes/issues/6440
I can see the CSS changes here fix the border issue in #6440 🎉
There are a few other changes that have been pulled into this branch from ongoing work on trunk. A rebase should fix this up so it's up to date with trunk before being merged. Please let us know if you'd like any help with this!
Hi @mikachan! Thank you for the feedback! I'm a relatively new contributor and I'm unfamiliar with rebasing. I'm just reading up on this now, but if possible would you mind walking me through the steps I need to take here?
Hey @gwensmithx, you may want to read https://git-scm.com/docs/git-rebase
@gwensmithx rebased and pushed the changes here.
This fix removes the border for the buttons. I guess the issue talks about text color being applied to space between outer border and background.
| Current | Expected |
|---|---|
 |
 |
Let me post a clarifying question in the original issue.
Thank you @madhusudhand! Maybe I misunderstood the original issue. From what I remember from my testing, a border was appearing that was the same colour as the text when a solid background fill was selected. I'll keep an eye for a response from your question in the original issue. Thanks again!