themes icon indicating copy to clipboard operation
themes copied to clipboard

#5189: Varia: Fix quote block font sizes

Open bobmatyas opened this issue 2 years ago • 2 comments

Changes proposed in this Pull Request:

Before
Editor
Screenshot on 2022-08-12 at 10-46-58(1)
Frontend
Screenshot on 2022-08-12 at 12-06-33
After
Frontend - Huge
Screenshot on 2022-08-12 at 11-40-15
Frontend - Small
Screenshot on 2022-08-12 at 11-41-22
Changes on Vaia Child Themes:
Screenshot on 2022-08-12 at 10-57-39 Screenshot on 2022-08-12 at 10-56-54

Related issue(s):

Fixes https://github.com/Automattic/themes/issues/5189 and Fixes https://github.com/Automattic/themes/issues/5581https://github.com/Automattic/themes/issues/5581

bobmatyas avatar Aug 12 '22 16:08 bobmatyas

This change causes the default size of the Quote block in the editor to not represent the current default CSS value of 1.5rem. (To reproduce, just add a quote block, save and observe size difference between view and editor.).

However, I wasn't able to reproduce the original issue in Exford or a few of the other themes noted in the original issue so I'm not sure this change is still necessary. Can you confirm that this is still a problem?

pbking avatar Aug 30 '22 15:08 pbking

I can still reproduce this issue on local sites and WordPress.com. If we change the font size on the quote block directly instead of the paragraph block, the font size change doesn't work.

I didn't notice there was a PR for this and was working on a fix on the Exford theme specifically 😢

To ensure the default font size will still work, I think we can just move the font-size property from selector blockquote p to blockquote, like this:

https://github.com/Automattic/themes/pull/6670/commits/6646fe92df009d7f5979872bf6c0668f041e7efb

From my tests, it worked just fine, and it didn't overwrite the custom font sizes or classes.

PS: I also noticed a similar issue with font sizes on the Pullquote block.

ccing: @bobmatyas

Gustavo-Hilario avatar Oct 14 '22 20:10 Gustavo-Hilario