themes icon indicating copy to clipboard operation
themes copied to clipboard

#66356: Lodestar: Home page: Full width blocks are not full width

Open Gustavo-Hilario opened this issue 2 years ago • 2 comments

Changes proposed in this Pull Request:

Removing a CSS selector that was preventing full-width blocks from being full width on the Lodestar home page.


Before After

Related issue(s):

Lodestar: Home page: Full width blocks are not full width Automattic/themes#6352

Fixes: https://github.com/Automattic/themes/issues/6352

Gustavo-Hilario avatar Aug 08 '22 18:08 Gustavo-Hilario

I see that the bit removed was originally added here on purpose. Does the original issue (wide and full elements in two-column layouts) still apply? Is it appropriately dealt with in another way?

pbking avatar Aug 09 '22 13:08 pbking

Yup, can confirm that the original reason that was applied is still valid: image

It only seems to matter if it's using 2 columns so maybe something specific to the .lodestar-panel two-column classes (or something) is necessary to remain.

pbking avatar Aug 09 '22 13:08 pbking

Thank you for the heads-up here, @pbking .

The code was allowing full-width content on all Lodestar panels, except the home page panel that has the lodestar-intro class, not lodestar-panel. I've added the code that will help with full-width content on the Lodestar home page.

Gustavo-Hilario avatar Sep 02 '22 15:09 Gustavo-Hilario