themes icon indicating copy to clipboard operation
themes copied to clipboard
verified publisher icon Automattic

Libre 2: Full-width, No Sidebar template isn't actually full width with the cover block

Open aisajib opened this issue 3 years ago • 1 comments

Quick summary

The Libre 2 theme includes a template called “Full width, no sidebar”. However, that template is not really full-width. Instead, the “Default template” is the one that’s full-width, if there is no sidebar active (no widgets added).

Steps to reproduce

  • Activate the Libre 2 theme: https://wordpress.com/theme/libre-2/
  • Open a page in the editor
  • Add a cover block, and set it to full-width
  • Choose the “Full width, no sidebar” template, and publish or preview the page.

What you expected to happen

The cover block should go full width (edge to edge). The screenshot below is taken with the Page Template set to "Default Template."

Screen Shot 2022-07-11 at 12 22 15 AM

What actually happened

With the Full-width, No Sidebar template selected, there are margins on both sides, unlike how it works when the Default template is selected.

Screenshot below is with the Full-width, No sidebar template selected.

Screen Shot 2022-07-11 at 12 23 10 AM

Context

Reported by an HC here: pd4QKa-Bx-p2

I noticed that if you have widgets in the sidebar, then the "default template" will not go full-width. That might be expected, but the Full Width, No Sidebar template not going full width is the issue we're reporting.

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

Looks like specific to the Libre-2 theme.

Browser, operating system and other notes

Chrome, macOS

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

Using Default Template seems to keep the Full-width Cover block truly full width.

aisajib avatar Jul 10 '22 18:07 aisajib

📌 HOUSEKEEPING

  • Labels ✅
  • Priority ✅
  • Replicable on Core - No

📌 SCRUBBING

  • Tested on P2 ✅
  • Tested on Simple ✅
  • Tested on AT ✅
  • Tested on Self-hosted - no

📌 FINDINGS/SCREENSHOTS/VIDEO

  • This is a classic theme which might not work as well with all Full width elements, however, as a workaround you can use the Layout Grid Block but note there is a bug with this too:

https://github.com/Automattic/themes/issues/2055

📌 ACTIONS

  • Marked as Triaged for Quality Squad review
  • Transferred to XYZ external repo: https://github.com/Automattic/themes/issues/

Robertght avatar Jul 15 '22 10:07 Robertght