themes icon indicating copy to clipboard operation
themes copied to clipboard

text-decoration shorthand with thickness has no support in WebKit browsers

Open madhusudhand opened this issue 3 years ago • 4 comments

Steps to replicate

Text decoration short hand that has thickness included makes the entire css style invalid in safari.

"typography": {
	"textDecoration": "none 0.25rem"
}
image

Browser support

image

Result

This effects following block themes.

  • [ ] Vivre
  • [ ] Pendant
  • [ ] Club (Work in progress)

Expected

Should separate text-decoration-tickness from theme.json and define in style.css

madhusudhand avatar Jul 15 '22 09:07 madhusudhand

"Safari, the new Internet Explorer"

pbking avatar Jul 15 '22 12:07 pbking

I rather think we should just close this one. I don't think we have an option to NOT use shorthand in a few places, at least not without/until a Gutenberg change. If anything this should be opened there I think (though I'm not sure exactly what the change should be... maybe including text-decoration-thickness as a Global Styles-able attribute?)

pbking avatar Aug 09 '22 17:08 pbking

I updated the title because I can confirm that isn't working with other WebKit browsers either.

Screenshot from 2022-08-12 12-43-32

matiasbenedetto avatar Aug 12 '22 10:08 matiasbenedetto

I took this approach for Disco: https://github.com/Automattic/themes/pull/6384

matiasbenedetto avatar Aug 12 '22 10:08 matiasbenedetto

Closing with https://github.com/Automattic/themes/pull/6490.

mikachan avatar Sep 01 '22 14:09 mikachan