themes icon indicating copy to clipboard operation
themes copied to clipboard

Classic themes(Publication, Button 2, Cubic): Image Block displayed with no bottom margin

Open liviopv opened this issue 3 years ago • 9 comments

Quick summary

It seems that a change in the markup of the Image Block has led to Image Blocks on the Publication theme to be displayed without any bottom margin, so any element without a top margin or padding (such as a Paragraph Block) is displayed directly below the image, with no gap.

Images that were inserted into the post before recent updates are displayed correctly while adding new Image Blocks lead to this issue.

Example of the old block markup: Markup on 2022-06-24 at 17:02:41

Example of the new block markup: Markup on 2022-06-24 at 17:04:09

Steps to reproduce

  1. Activate the Publication theme
  2. Create a new post or page
  3. Add a regular Image Block
  4. Add a regular Paragraph Block below the Image Block

What you expected to happen

There should be at least a small gap of white space between the image and the text.

What actually happened

The image and the text are displayed with no gap Markup on 2022-06-24 at 17:06:38

Context

Customer report

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

Publication https://wordpress.com/theme/publication

Browser, operating system and other notes

Tested on Chrome 102.0.5005.115, Mac OS 12.4

Reproducibility

Consistent

Severity

Most (> 50%)

Available workarounds?

Yes, easy to implement

Workaround details

div.wp-block-image {
    margin-bottom: 24px;
}

This seems to fix the issue without creating a new one

liviopv avatar Jun 24 '22 16:06 liviopv

📌 HOUSEKEEPING

  • Labels ✅
  • Priority ✅
  • Replicable on Core - Yes/No

📌 SCRUBBING

  • Tested on P2 - no
  • Tested on Simple ✅
  • Tested on AT ✅
  • Tested on Self-hosted - no

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I cannot replicate this and I noticed the markup follows the first structure mentioned above.

📌 ACTIONS

  • Await author feedback

📌 Message to Author

  • @liviopv is this present while using the Classic editor perhaps? Also, could you share the user report with us?

Robertght avatar Jun 24 '22 18:06 Robertght

Sorry, it's 5321946-zd-woothemes and 32693627-hc

This is the user post https://the-right-spirit.com/2019/09/13/nine-ryes-a-wheater-and-a-barely-legal-bourbon-walk-into-a-bar/ there's a good chance it was previously edited in the Classic Editor. If it's not due to a change in the markup, it's likely a bug that always existed in the theme and was never reported, as it was easily reproducible in my site: p6VVUQ-DC-p2 cc @arunsathiya in case you have more info

liviopv avatar Jun 27 '22 16:06 liviopv

I could also replicate this issue with the Button 2 theme. If we add several single image blocks on top of each other, the images will be glued with no space below each of them.

Customer report: 5348246-zen Theme: Button 2

Screenshot:

Markup on 2022-07-04 at 18:47:00

Workaround: User the Gallery block instead

Gustavo-Hilario avatar Jul 04 '22 21:07 Gustavo-Hilario

Theme Cubic also suddenly has missing bottom-margins for images but only on smaller screens. Margin gets added with screen size min-width: 768px

Customer report: 5347881-zen Theme: Cubic

Screenshot: 2022-07-07_10-23-28

MaxPhilip avatar Jul 07 '22 08:07 MaxPhilip

Based on the previous reports, it appears Classic themes and using the Classic editor could generate these margin issues.

Robertght avatar Jul 12 '22 18:07 Robertght

Also happening on Baskerville 2 User reported on 37369570-hc and created follow-up 5623884-zd-woothemes as requested.

hngdny avatar Oct 11 '22 20:10 hngdny

Support References

This comment is automatically generated. Please do not edit it.

  • [ ] 5321946-zen
  • [ ] 5348246-zen
  • [ ] 5347881-zen
  • [ ] 5623884-zen
  • [ ] 5691088-zen
  • [ ] 5723215-zen

github-actions[bot] avatar Oct 11 '22 20:10 github-actions[bot]

Additional ticket from a closed duplicate

  • 5691088-zen

kavyagokul avatar Nov 10 '22 12:11 kavyagokul

Additional ticket from closed duplicate

  • 5723215-zen

kavyagokul avatar Nov 22 '22 14:11 kavyagokul