themes icon indicating copy to clipboard operation
themes copied to clipboard

Blockbase/Attar: Hide Footer Credit Leaves a Visible Empty Group Block Below Footer

Open dcoleonline opened this issue 2 years ago • 9 comments

Quick summary

The Hide Footer Credit feature in the customizer does not remove the space that the footer credit occupies.

This is what it looks like with the default footer credit. The grey area is the footer element:

image

The group block appears below the footer element:

image

When the footer credit is hidden, the text of the credit is removed, but the empty space below the footer remains: image

Here is the HTML when the footer credit is hidden:

image

Steps to reproduce

  1. Activate Attar
  2. Use FSE to delete the footer's paragraph block which contains the footer credit
  3. Visit a page and see that the footer credit is now added below the footer element.
  4. Hide the footer credit in the customizer.
  5. See that the space that the footer credit occupies remains even when the credit is hidden.

What you expected to happen

There would not be a group block below the footer if the footer credit is being hidden. I expected that the div.wp-block-group would not exist below the <footer> element.

What actually happened

The footer credit text was hidden, but the block group that contains the footer credit remained. This leaves an unexpected empty space below the site footer.

Context

Customer report in 5254315-zd (WordPress.com Pro plan)

Simple, Atomic or both?

No response

Theme-specific issue?

Confirmed on Attar

Browser, operating system and other notes

No response

Reproducibility

No response

Severity

No response

Available workarounds?

No response

Workaround details

This doesn't happen if the footer credit paragraph is not removed from the footer element via FSE.

dcoleonline avatar May 30 '22 01:05 dcoleonline

Another report: 399646-hc Theme: Russell

hacchism avatar Jun 02 '22 01:06 hacchism

📌 HOUSEKEEPING

  • Labels ✅
  • Priority ✅

📌 SCRUBBING

  • Tested on Simple ✅
  • Tested on AT ✅

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Context: to confirm, this happens on AT sites with the Blockbase theme as well.

📌 ACTIONS

  • Transferred to the themes repo.

Robertght avatar Jun 05 '22 10:06 Robertght

  • [ ] Another report here on a custom Blockbase child theme: 36046918-hc Follow up ticket created here: 5367615-zd-woothemes The user shared that this a very common issue on FSE and would love it could get some more attention. (They have quite a number of sites.)

tellisbethel avatar Jul 12 '22 13:07 tellisbethel

Another one: 5461208-ZD

Theme: Dorna

mdtanjid0 avatar Aug 08 '22 06:08 mdtanjid0

ANother one in 36410499-hc

Theme: Heiwa

kavyagokul avatar Aug 10 '22 11:08 kavyagokul

Another report: 5482345-zd Theme: Attar

Shared CSS as a workaround

body.woocommerce footer + .wp-block-group {
    display: none;
}

dolgelukkig avatar Aug 17 '22 10:08 dolgelukkig

Reports from https://github.com/Automattic/wp-calypso/issues/65344


5356004-zd-woothemes

  • Theme: Byrne CSS Workaround provided:
.wp-site-blocks > div.wp-block-group:last-child {
    margin-top: 0;
    height: 0; 
}

5467273-zd-woothemes

  • Theme: Heiwa CSS Workaround provided:
.site-header {
  padding-top: 0px !important;
  padding-bottom: 0px !important;
}

cuemarie avatar Sep 21 '22 00:09 cuemarie

Support References

This comment is automatically generated. Please do not edit it.

  • [ ] 5254315-zen
  • [ ] 5367615-zen
  • [ ] 5461208-zen
  • [ ] 5482345-zen
  • [ ] 5356004-zen
  • [ ] 5467273-zen
  • [ ] 5634347-zen
  • [ ] 5830896-zen
  • [ ] 5835132-zen

github-actions[bot] avatar Sep 21 '22 00:09 github-actions[bot]

Another one 5634347-zd

Theme: byrne ( child of blockbase-premium ).

mdtanjid0 avatar Oct 16 '22 10:10 mdtanjid0

Another report in 5830896-zd-woothemes (Heiwa).

Gave CSS as a workaround:

footer.site-footer-container + div.wp-block-group {
    display: none;
}

jp-imagines avatar Jan 02 '23 20:01 jp-imagines

Blockbase

  • [ ] 5835132-zd-woothemes

liviopv avatar Jan 04 '23 14:01 liviopv

This was also brought up to the Build team by Codeable.

p1675163387825869-slack-C04C3KCM42H

cometgrrl avatar Feb 06 '23 23:02 cometgrrl

Another in

  • [ ] 39515879-hc

Theme: Thriving Artist

liviopv avatar Feb 09 '23 10:02 liviopv