themes icon indicating copy to clipboard operation
themes copied to clipboard

Lodestar: Removing italics in verse block to respect the block toolbar

Open aetta opened this issue 4 years ago • 3 comments

Removed font-style: italic from:

blocks.css editor-blocks.css

This also fix #4363

aetta avatar Aug 23 '21 14:08 aetta

This will change users' sites who may be happy with the italic version of the block. Can we find a solution that provides italic as default but without overriding the user selection from the toolbar?

MaggieCabrera avatar Apr 18 '22 10:04 MaggieCabrera

Hi @MaggieCabrera, that makes sense! A possible solution would be to use the emphasis element , adding the font-face: italic; to it, and in another verse block, the font-face: normal;

Another possible solution is to change the font-face of the block by the element inherited from the parent.

Both should show the same result!

1

.wp-block-verse em {
	background: transparent;
	font-family: inherit;
	font-style: italic;
	padding: 0;
}

.wp-block-verse {
	background: transparent;
	font-family: inherit;
	font-style: normal;
	padding: 0;
}

2

.wp-block-verse {
	background: transparent;
	font-family: inherit;
	font-style: inherit;
	padding: 0;
}

What do you think? :)

aetta avatar Apr 19 '22 19:04 aetta

Hi @MaggieCabrera, that makes sense! A possible solution would be to use the emphasis element , adding the font-face: italic; to it, and in another verse block, the font-face: normal; _ Another possible solution is to change the font-face of the block by the element inherited from the parent. Both should show the same result! 1 .wp-block-verse em { background: transparent; font-family: inherit; font-style: italic; padding: 0; } .wp-block-verse { background: transparent; font-family: inherit; font-style: normal; padding: 0; } 2 .wp-block-verse { background: transparent; font-family: inherit; font-style: inherit; padding: 0; } What do you think? :)_

The first solution requires the user to make a change to achieve what the theme was doing by default. We want to try and not affect user's existing sites, in case they have this in multiple places, so they don't have to edit all of their posts to revert our change.

I'm not sure if the second solution would work, since I'm not sure if the parent has the correct rules to inherit from? I'd have to test that

MaggieCabrera avatar Apr 22 '22 08:04 MaggieCabrera