themes icon indicating copy to clipboard operation
themes copied to clipboard

Alto Focus: Update editor styles

Open scruffian opened this issue 4 years ago • 3 comments

Changes proposed in this Pull Request:

This adds theme support for editor styles and updates the editor styles so that the frontend and the editor match. Ideally we wouldn't need editor styles at all, but there's no consistent way to target editor content at the moment.

Related issue(s):

Part of #3280

scruffian avatar Feb 16 '21 15:02 scruffian

To get this working on your wpcom sandbox you need to point remote requests from your sandbox. You can use this code to do that: 286f7-pb/#php. You'll need to add your test site url to the array for it to work.

scruffian avatar Feb 17 '21 17:02 scruffian

🚢

jffng avatar Feb 17 '21 20:02 jffng

I changed the approach here. By using local file references rather than URLs we can avoid the environmental issues above.

I also decided to try to move closer to having the same styles for front end and the editor. We now add all style to the editor. I have removed duplicated styles from the editor-blocks.css file. Ideally we'd only have one file that works for both, but that would require a lot of reviewing and testing. This is a first step towards that

scruffian avatar Feb 18 '21 08:02 scruffian