themes icon indicating copy to clipboard operation
themes copied to clipboard

Published 20 hours ago • verified publisher icon Automattic

Penscratch 2: Improve readability of links

Open nielslange opened this issue 4 years ago • 3 comments

Fixes #1905

Editor Before:

#1905-editor-before

 Editor After:

#1905-editor-after
Frontend Before:

#1905-frontend-before

 Frontend After:

#1905-frontend-after

nielslange avatar Apr 13 '20 13:04 nielslange

I don't think it's wise to suddenly change the front-end visual appearance of links on a theme used by many people for many years. There will be no recourse for people without custom CSS who didn't want their links underlined.

kathrynwp avatar Apr 13 '20 13:04 kathrynwp

I don't think it's wise to suddenly change the front-end visual appearance of links on a theme used by many people for many years. There will be no recourse for people without custom CSS who didn't want their links underlined.

I'm aware of that, @kathrynwp. I simply believe that the current implementation is a major accessibility issue. The reason not to address this usability issue simply because lots of people are using the theme doesn't sound like the best approach. That said, it's not up to me to decide whether this PR gets merged or will be deleted. ¯_(ツ)_/¯

nielslange avatar Apr 14 '20 05:04 nielslange

I don't think it's wise to suddenly change the front-end visual appearance of links on a theme used by many people for many years. There will be no recourse for people without custom CSS who didn't want their links underlined.

That's why I suggested in the original ticket making the text colours configurable by the blog owner and leaving it up to them to do something about it. Finding colours that work for all kinds of colour blindness without being ugly for people with normal vision is tricky, but possible.

DrHyde avatar Apr 25 '20 22:04 DrHyde